Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2039243002: Revert "New tests for initializing formal access." (Closed)

Created:
4 years, 6 months ago by eernst
Modified:
4 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "New tests for initializing formal access." This reverts commit 543a51ff3eb1488e2c1938bfcd8779f0d634900c because several status file updates are needed. Committed: https://github.com/dart-lang/sdk/commit/6d56db592b139e52a75a96f06f626bdc07e518df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -116 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 4 chunks +4 lines, -17 lines 0 comments Download
M pkg/dart_messages/lib/shared_messages.dart View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/language/initializing_formal_capture_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/language/initializing_formal_final_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/language/initializing_formal_promotion_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/language/initializing_formal_type_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
TBR: Reverting because several status file updates are needed.
4 years, 6 months ago (2016-06-06 14:06:56 UTC) #2
eernst
Committed patchset #1 (id:1) manually as 6d56db592b139e52a75a96f06f626bdc07e518df (presubmit successful).
4 years, 6 months ago (2016-06-06 14:07:17 UTC) #4
Johnni Winther
4 years, 6 months ago (2016-06-07 07:50:43 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698