Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2039233003: Showing virtual keyboard when input type changed (Closed)

Created:
4 years, 6 months ago by takaoka
Modified:
4 years, 6 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, hidehiko+watch_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, qsr+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Showing virtual keyboard when input type changed This CL tries showing virtual keyboard everytime ARC reports that text input type is changed, even when the type isn't actually changed. BUG=581282 BUG=b/27747791 BUG=b/28677278 Committed: https://crrev.com/d9457f17224b5eec57c5d974213ed58591595837 Cr-Commit-Position: refs/heads/master@{#399672}

Patch Set 1 : Add ImeHost.ShowImeIfNeeded to ARC bridge #

Total comments: 4

Patch Set 2 : Add ImeHost.ShowImeIfNeeded to ARC bridge #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M components/arc/common/ime.mojom View 2 chunks +4 lines, -0 lines 0 comments Download
M components/arc/ime/arc_ime_bridge.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/ime/arc_ime_bridge_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/ime/arc_ime_bridge_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/arc/ime/arc_ime_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/ime/arc_ime_service.cc View 1 2 chunks +9 lines, -5 lines 2 comments Download

Messages

Total messages: 17 (7 generated)
takaoka
PTAL?
4 years, 6 months ago (2016-06-14 04:12:22 UTC) #5
kinaba
https://codereview.chromium.org/2039233003/diff/40001/components/arc/ime/arc_ime_service.cc File components/arc/ime/arc_ime_service.cc (left): https://codereview.chromium.org/2039233003/diff/40001/components/arc/ime/arc_ime_service.cc#oldcode129 components/arc/ime/arc_ime_service.cc:129: if (ime_type_ == type) Although it's a matter of ...
4 years, 6 months ago (2016-06-14 04:22:08 UTC) #6
takaoka
PTAL at Patch Set 2? https://codereview.chromium.org/2039233003/diff/40001/components/arc/ime/arc_ime_service.cc File components/arc/ime/arc_ime_service.cc (left): https://codereview.chromium.org/2039233003/diff/40001/components/arc/ime/arc_ime_service.cc#oldcode129 components/arc/ime/arc_ime_service.cc:129: if (ime_type_ == type) ...
4 years, 6 months ago (2016-06-14 05:55:51 UTC) #7
kinaba
lgtm
4 years, 6 months ago (2016-06-14 05:56:58 UTC) #8
hidehiko
lgtm
4 years, 6 months ago (2016-06-14 06:06:34 UTC) #9
dcheng
mojom lgtm with a question to help confirm I understand what's going on =) https://codereview.chromium.org/2039233003/diff/60001/components/arc/ime/arc_ime_service.cc ...
4 years, 6 months ago (2016-06-14 08:39:52 UTC) #10
takaoka
https://codereview.chromium.org/2039233003/diff/60001/components/arc/ime/arc_ime_service.cc File components/arc/ime/arc_ime_service.cc (right): https://codereview.chromium.org/2039233003/diff/60001/components/arc/ime/arc_ime_service.cc#newcode139 components/arc/ime/arc_ime_service.cc:139: ime_type_ != ui::TEXT_INPUT_TYPE_NONE) { On 2016/06/14 08:39:52, dcheng wrote: ...
4 years, 6 months ago (2016-06-14 09:04:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039233003/60001
4 years, 6 months ago (2016-06-14 09:04:49 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 6 months ago (2016-06-14 09:08:59 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 09:10:56 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9457f17224b5eec57c5d974213ed58591595837
Cr-Commit-Position: refs/heads/master@{#399672}

Powered by Google App Engine
This is Rietveld 408576698