Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2039233002: Allow the exact DOM Code value to be sent from layout tests. (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, mlamouri+watch-test-runner_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow the exact DOM Code value to be sent from layout tests. With the conversion to keyIdentifier there are some issues that need to be fixed with layout tests. Add the exact string identifiers to event_sender so that it is clear between the LayoutTests and the implementation the identifier can be the same. BUG=607349 Committed: https://crrev.com/96d32db9c9cf09cbf291d85533bfd5386e9319f2 Cr-Commit-Position: refs/heads/master@{#398030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -22 lines) Patch
M components/test_runner/event_sender.cc View 1 chunk +46 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dtapuska
4 years, 6 months ago (2016-06-06 14:38:17 UTC) #3
Rick Byers
LGTM
4 years, 6 months ago (2016-06-06 14:59:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039233002/1
4 years, 6 months ago (2016-06-06 15:05:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 15:19:37 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 15:21:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96d32db9c9cf09cbf291d85533bfd5386e9319f2
Cr-Commit-Position: refs/heads/master@{#398030}

Powered by Google App Engine
This is Rietveld 408576698