third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2039223002: [css-grid] Fix percentage height on grid item's children

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2039223002: [css-grid] Fix percentage height on grid item's children (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: New version using overrideLogicalContentHeight Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 9137ecf1dc9429612d281307f6f2dbf45e1b35a7..f760f4c05c473670efff8a3d7e8f2dba5f5de787 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -2733,6 +2733,8 @@ LayoutUnit LayoutBox::computePercentageLogicalHeight(const Length& height) const

availableHeight = stretchedFlexHeight;

} else if (hasOverrideContainingBlockLogicalHeight() && !isOutOfFlowPositionedWithSpecifiedHeight) {

availableHeight = overrideContainingBlockContentLogicalHeight();

+ } else if (cb->isGridItem() && cb->hasOverrideLogicalContentHeight()) {

+ availableHeight = cb->overrideLogicalContentHeight();

} else if (cbstyle.logicalHeight().isFixed()) {

LayoutUnit contentBoxHeight = cb->adjustContentBoxLogicalHeightForBoxSizing(cbstyle.logicalHeight().value());

availableHeight = cb->constrainContentBoxLogicalHeightByMinMax(

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-resolution-grid-item-children.html ('k') | no next file » | no next file with comments »