third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h - Issue 2039113003: Make removeChild faster with active ranges

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

Issue 2039113003: Make removeChild faster with active ranges (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-06-06T16:21:06 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

diff --git a/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h b/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

index 401a563078cd906d230b6eb010c7f4819295cefc..7816917472ca3e7ee40f95fe443d98d37f4cafac 100644

--- a/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

+++ b/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

@@ -211,8 +211,10 @@ inline void RangeBoundaryPoint::setToEndOfNode(Node& container)

inline void RangeBoundaryPoint::childBeforeWillBeRemoved()

{

- DCHECK(m_offsetInContainer);

m_childBeforeBoundary = m_childBeforeBoundary->previousSibling();

+ if (!isOffsetValid())

+ return;

+ DCHECK_GT(m_offsetInContainer, 0);

if (!m_childBeforeBoundary)

m_offsetInContainer = 0;

else if (m_offsetInContainer > 0)

« no previous file with comments | « third_party/WebKit/Source/core/dom/Range.cpp ('k') | no next file » | no next file with comments »