Pass bound values as const values to the bound function

Pass bound values in base::Bind as const values

This CL replace a static_assert() in base::Bind with "const" qualifier
check to make base::Bind simpler.

base::Bind has static_assert()s to prevent the target function from
modifying the bound variable directly. But, it uses complex templates
and is hard to read. The same check can be done by passing the values
as const ones.

BUG=554299
Committed: https://crrev.com/9921447d7642c8c0532e926076782facbc62bcb5
Cr-Commit-Position: refs/heads/master@{#402059}

[tzik, 2016-06-06 09:05:44]

Description was changed from

==========
Pass bound values as const values to the bound function

base::Bind asserts bound parameters not to be a non-const reference,
and passes the bound variable as non-const values on the existing code.
That prevents the target function to modify the BindState's internal
storage directly.

This CL makes bound parameters passed as const values to the target
function, so that the assertion can be safely removed.

BUG=
==========

to

==========
Pass out bound values in base::Bind as const values

base::Bind asserts bound parameters not to be a non-const reference,
and passes the bound variable as non-const values on the existing code.
That prevents the target function to modify the BindState's internal
storage directly.

This CL makes bound parameters passed as const values to the target
function, so that the assertion can be safely removed and base::Bind
can get simpler.

BUG=
==========

[tzik, 2016-06-06 12:46:21]

Description was changed from

==========
Pass out bound values in base::Bind as const values

base::Bind asserts bound parameters not to be a non-const reference,
and passes the bound variable as non-const values on the existing code.
That prevents the target function to modify the BindState's internal
storage directly.

This CL makes bound parameters passed as const values to the target
function, so that the assertion can be safely removed and base::Bind
can get simpler.

BUG=
==========

to

==========
Pass bound values in base::Bind as const values

This CL replace a static_assert() in base::Bind with "const" qualifier
check.

base::Bind has static_assert()s to prevent the target function from
modifying the bound variable directly. But, it uses complex templates
and is hard to read. The same check can be done by passing the values
as const ones.

BUG=
==========

[tzik, 2016-06-06 14:42:25]

Description was changed from

==========
Pass bound values in base::Bind as const values

This CL replace a static_assert() in base::Bind with "const" qualifier
check.

base::Bind has static_assert()s to prevent the target function from
modifying the bound variable directly. But, it uses complex templates
and is hard to read. The same check can be done by passing the values
as const ones.

BUG=
==========

to

==========
Pass bound values in base::Bind as const values

This CL replace a static_assert() in base::Bind with "const" qualifier
check to make base::Bind simpler.

base::Bind has static_assert()s to prevent the target function from
modifying the bound variable directly. But, it uses complex templates
and is hard to read. The same check can be done by passing the values
as const ones.

BUG=554299
==========

[tzik, 2016-06-06 14:42:25]

tzik@chromium.org changed reviewers:
+ thakis@chromium.org

[tzik, 2016-06-06 14:44:15]

PTAL

[tzik, 2016-06-24 02:09:33]

tzik@chromium.org changed reviewers:
+ yutak@chromium.org

[tzik, 2016-06-24 02:09:33]

yutak: Could you take a look?

[Yuta Kitamura, 2016-06-24 06:41:39]

LGTM, this looks okay.

[danakj, 2016-06-24 18:44:54]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-06-24 18:44:55]

LGTM also

[tzik, 2016-06-25 08:02:44]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-06-25 08:02:44]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/2039093002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-25 08:02:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-25 09:59:51]

Description was changed from

==========
Pass bound values in base::Bind as const values

This CL replace a static_assert() in base::Bind with "const" qualifier
check to make base::Bind simpler.

base::Bind has static_assert()s to prevent the target function from
modifying the bound variable directly. But, it uses complex templates
and is hard to read. The same check can be done by passing the values
as const ones.

BUG=554299
==========

to

==========
Pass bound values in base::Bind as const values

This CL replace a static_assert() in base::Bind with "const" qualifier
check to make base::Bind simpler.

base::Bind has static_assert()s to prevent the target function from
modifying the bound variable directly. But, it uses complex templates
and is hard to read. The same check can be done by passing the values
as const ones.

BUG=554299
==========

[commit-bot: I haz the power, 2016-06-25 09:59:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-25 10:01:25]

Description was changed from

==========
Pass bound values in base::Bind as const values

This CL replace a static_assert() in base::Bind with "const" qualifier
check to make base::Bind simpler.

base::Bind has static_assert()s to prevent the target function from
modifying the bound variable directly. But, it uses complex templates
and is hard to read. The same check can be done by passing the values
as const ones.

BUG=554299
==========

to

==========
Pass bound values in base::Bind as const values

This CL replace a static_assert() in base::Bind with "const" qualifier
check to make base::Bind simpler.

base::Bind has static_assert()s to prevent the target function from
modifying the bound variable directly. But, it uses complex templates
and is hard to read. The same check can be done by passing the values
as const ones.

BUG=554299

Committed: https://crrev.com/9921447d7642c8c0532e926076782facbc62bcb5
Cr-Commit-Position: refs/heads/master@{#402059}
==========

[commit-bot: I haz the power, 2016-06-25 10:01:26]

Patchset 3 (id:??) landed as
https://crrev.com/9921447d7642c8c0532e926076782facbc62bcb5
Cr-Commit-Position: refs/heads/master@{#402059}