Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2039043003: Remove //base dependency (Closed)

Created:
4 years, 6 months ago by wychen
Modified:
4 years, 4 months ago
Reviewers:
mdjones, nyquist, dcheng
Base URL:
git@github.com:chromium/dom-distiller.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove //base dependency The C header file for proto JSON was generated here, checked in to the distribution repository, and rolled into Chromium. It is not allowed to have //base dependency on external repos, so the file generation should be moved to Chromium. The ant target "protoc.json" is removed, and plugin_pb2.py is exported to the distribution repo. This goes along with https://codereview.chromium.org/2034373002/ BUG=572585 R=mdjones@chromium.org, nyquist@chromium.org Committed: b21e6a334aceafa22f326b9d148cae01aecc586c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -288 lines) Patch
M build.xml View 2 chunks +3 lines, -15 lines 0 comments Download
D protoc_plugins/json_values_converter.py View 1 chunk +0 lines, -273 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
wychen
PTAL
4 years, 6 months ago (2016-06-06 18:45:06 UTC) #3
nyquist
lgtm
4 years, 6 months ago (2016-06-16 17:51:30 UTC) #4
mdjones
lgtm
4 years, 6 months ago (2016-06-16 20:47:18 UTC) #5
wychen
4 years, 4 months ago (2016-08-15 23:21:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b21e6a334aceafa22f326b9d148cae01aecc586c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698