Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: src/compiler/common-node-cache.h

Issue 2039023002: [turbofan] Robust node caching for relocatable int{32|64} (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/js-graph.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/common-node-cache.h
diff --git a/src/compiler/common-node-cache.h b/src/compiler/common-node-cache.h
index cee0c4e837c6c4706c7fb03368534deb554bbd45..1f07703e72395192a0e911f4e3e75046f3a3754b 100644
--- a/src/compiler/common-node-cache.h
+++ b/src/compiler/common-node-cache.h
@@ -52,12 +52,14 @@ class CommonNodeCache final {
Node** FindHeapConstant(Handle<HeapObject> value);
- Node** FindRelocatableInt32Constant(int32_t value) {
- return relocatable_int32_constants_.Find(zone(), value);
+ Node** FindRelocatableInt32Constant(int32_t value, RelocInfoMode rmode) {
+ return relocatable_int32_constants_.Find(zone(),
+ std::make_pair(value, rmode));
}
- Node** FindRelocatableInt64Constant(int64_t value) {
- return relocatable_int64_constants_.Find(zone(), value);
+ Node** FindRelocatableInt64Constant(int64_t value, RelocInfoMode rmode) {
+ return relocatable_int64_constants_.Find(zone(),
+ std::make_pair(value, rmode));
}
// Return all nodes from the cache.
@@ -73,8 +75,8 @@ class CommonNodeCache final {
IntPtrNodeCache external_constants_;
Int64NodeCache number_constants_;
IntPtrNodeCache heap_constants_;
- Int32NodeCache relocatable_int32_constants_;
- Int64NodeCache relocatable_int64_constants_;
+ RelocInt32NodeCache relocatable_int32_constants_;
+ RelocInt64NodeCache relocatable_int64_constants_;
Zone* const zone_;
DISALLOW_COPY_AND_ASSIGN(CommonNodeCache);
« no previous file with comments | « no previous file | src/compiler/js-graph.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698