Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/compiler/common-node-cache.h

Issue 2039023002: [turbofan] Robust node caching for relocatable int{32|64} (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/js-graph.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_COMMON_NODE_CACHE_H_ 5 #ifndef V8_COMPILER_COMMON_NODE_CACHE_H_
6 #define V8_COMPILER_COMMON_NODE_CACHE_H_ 6 #define V8_COMPILER_COMMON_NODE_CACHE_H_
7 7
8 #include "src/compiler/node-cache.h" 8 #include "src/compiler/node-cache.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 Node** FindExternalConstant(ExternalReference value); 46 Node** FindExternalConstant(ExternalReference value);
47 47
48 Node** FindNumberConstant(double value) { 48 Node** FindNumberConstant(double value) {
49 // We canonicalize double constants at the bit representation level. 49 // We canonicalize double constants at the bit representation level.
50 return number_constants_.Find(zone(), bit_cast<int64_t>(value)); 50 return number_constants_.Find(zone(), bit_cast<int64_t>(value));
51 } 51 }
52 52
53 Node** FindHeapConstant(Handle<HeapObject> value); 53 Node** FindHeapConstant(Handle<HeapObject> value);
54 54
55 Node** FindRelocatableInt32Constant(int32_t value) { 55 Node** FindRelocatableInt32Constant(int32_t value, RelocInfoMode rmode) {
56 return relocatable_int32_constants_.Find(zone(), value); 56 return relocatable_int32_constants_.Find(zone(),
57 std::make_pair(value, rmode));
57 } 58 }
58 59
59 Node** FindRelocatableInt64Constant(int64_t value) { 60 Node** FindRelocatableInt64Constant(int64_t value, RelocInfoMode rmode) {
60 return relocatable_int64_constants_.Find(zone(), value); 61 return relocatable_int64_constants_.Find(zone(),
62 std::make_pair(value, rmode));
61 } 63 }
62 64
63 // Return all nodes from the cache. 65 // Return all nodes from the cache.
64 void GetCachedNodes(ZoneVector<Node*>* nodes); 66 void GetCachedNodes(ZoneVector<Node*>* nodes);
65 67
66 Zone* zone() const { return zone_; } 68 Zone* zone() const { return zone_; }
67 69
68 private: 70 private:
69 Int32NodeCache int32_constants_; 71 Int32NodeCache int32_constants_;
70 Int64NodeCache int64_constants_; 72 Int64NodeCache int64_constants_;
71 Int32NodeCache float32_constants_; 73 Int32NodeCache float32_constants_;
72 Int64NodeCache float64_constants_; 74 Int64NodeCache float64_constants_;
73 IntPtrNodeCache external_constants_; 75 IntPtrNodeCache external_constants_;
74 Int64NodeCache number_constants_; 76 Int64NodeCache number_constants_;
75 IntPtrNodeCache heap_constants_; 77 IntPtrNodeCache heap_constants_;
76 Int32NodeCache relocatable_int32_constants_; 78 RelocInt32NodeCache relocatable_int32_constants_;
77 Int64NodeCache relocatable_int64_constants_; 79 RelocInt64NodeCache relocatable_int64_constants_;
78 Zone* const zone_; 80 Zone* const zone_;
79 81
80 DISALLOW_COPY_AND_ASSIGN(CommonNodeCache); 82 DISALLOW_COPY_AND_ASSIGN(CommonNodeCache);
81 }; 83 };
82 84
83 } // namespace compiler 85 } // namespace compiler
84 } // namespace internal 86 } // namespace internal
85 } // namespace v8 87 } // namespace v8
86 88
87 #endif // V8_COMPILER_COMMON_NODE_CACHE_H_ 89 #endif // V8_COMPILER_COMMON_NODE_CACHE_H_
OLDNEW
« no previous file with comments | « no previous file | src/compiler/js-graph.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698