Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2039023002: [turbofan] Robust node caching for relocatable int{32|64} (Closed)

Created:
4 years, 6 months ago by Mircea Trofin
Modified:
4 years, 6 months ago
Reviewers:
gdeepti, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Robust node caching for relocatable int{32|64} We should use both the int value as well as the reloc info mode for the key of a relocatable int{32|64}. BUG= Committed: https://crrev.com/c0c3a23101d0d0f4ceacef0399f84b23de3bb857 Cr-Commit-Position: refs/heads/master@{#36762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M src/compiler/common-node-cache.h View 2 chunks +8 lines, -6 lines 0 comments Download
M src/compiler/js-graph.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/node-cache.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/node-cache.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Mircea Trofin
I hit this when trying to tease out wasm imports as well as direct function ...
4 years, 6 months ago (2016-06-04 05:13:29 UTC) #3
gdeepti
lgtm, +titzer These were only used for wasm memory references so I did not see ...
4 years, 6 months ago (2016-06-06 15:47:25 UTC) #5
titzer
lgtm
4 years, 6 months ago (2016-06-06 15:58:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039023002/1
4 years, 6 months ago (2016-06-06 16:20:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 16:45:30 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 16:47:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0c3a23101d0d0f4ceacef0399f84b23de3bb857
Cr-Commit-Position: refs/heads/master@{#36762}

Powered by Google App Engine
This is Rietveld 408576698