Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2038993002: Added my name to the AUTHORS file, added Yakkety support in (Closed)

Created:
4 years, 6 months ago by tsimonq2
Modified:
3 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added my name to the AUTHORS file, added Yakkety support in build/install-build-deps.sh, removed EOL releases from build/install-build-deps.sh BUG=617373 TEST=Use a supported release of Ubuntu and try to execute src/build/install-build-deps.sh, it should display properly.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M build/install-build-deps.sh View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
jungshik at Google
On 2016/06/04 02:22:12, tsimonq2 wrote: > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=sqawesome99@gmail.com changed reviewers: > + https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=jshin@chromium.org Sorry for the ...
4 years, 6 months ago (2016-06-12 10:30:51 UTC) #3
jungshik at Google
dpranke@, can you approve? Thanks
4 years, 6 months ago (2016-06-12 10:34:56 UTC) #5
tsimonq2
Sorry, git blame gave me your details. Thank you for editing the reviewer.
4 years, 6 months ago (2016-06-12 16:44:31 UTC) #7
jungshik at Google
On 2016/06/12 16:44:31, tsimonq2 wrote: > Sorry, git blame gave me your details. Thank you ...
4 years, 6 months ago (2016-06-13 06:32:12 UTC) #8
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-14 20:36:41 UTC) #9
Dirk Pranke
sorry for the delay, was ooo yesterday ...
4 years, 6 months ago (2016-06-14 20:36:58 UTC) #10
Dirk Pranke
Sorry for not getting to this for some time. Can you sign the CLA so ...
4 years, 3 months ago (2016-08-31 23:39:30 UTC) #11
tsimonq2
I already signed it... Agreement Name Date Signed Manage Google Individual CLA Simon Quigley Jun ...
4 years, 3 months ago (2016-09-01 02:41:03 UTC) #12
Dirk Pranke
On 2016/09/01 02:41:03, tsimonq2 wrote: > I already signed it... > > Agreement Name Date ...
4 years, 3 months ago (2016-09-01 03:19:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2038993002/1
4 years, 3 months ago (2016-09-01 03:20:00 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/250908)
4 years, 3 months ago (2016-09-01 03:26:00 UTC) #17
Dirk Pranke
On 2016/09/01 03:26:00, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-01 03:40:06 UTC) #18
tsimonq2
I apologize for the delay here, but I'm not remembering how to add commits to ...
4 years, 2 months ago (2016-10-10 03:38:09 UTC) #19
Dirk Pranke
On 2016/10/10 03:38:09, tsimonq2 wrote: > I apologize for the delay here, but I'm not ...
4 years, 2 months ago (2016-10-11 00:04:46 UTC) #20
tsimonq2
On 2016/10/11 00:06:05, tsimonq2 wrote: > The CQ bit was unchecked by mailto:sqawesome99@gmail.com Whoops, wrong ...
4 years, 2 months ago (2016-10-11 00:06:20 UTC) #23
Dirk Pranke
3 years, 5 months ago (2017-07-14 00:12:33 UTC) #24
Message was sent while issue was closed.
Closing, it looks like we never landed this but the support got added some other
way.

Powered by Google App Engine
This is Rietveld 408576698