|
|
Chromium Code Reviews|
Created:
4 years, 6 months ago by tsimonq2 Modified:
3 years, 5 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdded my name to the AUTHORS file, added Yakkety support in
build/install-build-deps.sh, removed EOL releases from
build/install-build-deps.sh
BUG=617373
TEST=Use a supported release of Ubuntu and try to execute src/build/install-build-deps.sh, it should display properly.
Patch Set 1 #Messages
Total messages: 24 (8 generated)
Description was changed from ========== Added my name to the AUTHORS file, added Yakkety support in build/install-build-deps.sh, removed EOL releases from build/install-build-deps.sh BUG=617373 TEST=Use a supported release of Ubuntu and try to execute src/build/install-build-deps.sh, it should display properly. ========== to ========== Added my name to the AUTHORS file, added Yakkety support in build/install-build-deps.sh, removed EOL releases from build/install-build-deps.sh BUG=617373 TEST=Use a supported release of Ubuntu and try to execute src/build/install-build-deps.sh, it should display properly. ==========
sqawesome99@gmail.com changed reviewers: + jshin@chromium.org
On 2016/06/04 02:22:12, tsimonq2 wrote: > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=sqawesome99@gmail.com changed reviewers: > + https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=jshin@chromium.org Sorry for the late reply. I think you'd better ask somebody who worked on install-build-deps.sh to review your change. Note that I'm not an OWNER of build/ directory so that my review will not help :-) CQ will reject the CL without an owner's approval. I did find that you already signed CLA. So adding your name to AUTHORS is fine.
jshin@chromium.org changed reviewers: + dpranke@chromium.org
dpranke@, can you approve? Thanks
jshin@chromium.org changed reviewers: - jshin@chromium.org
Sorry, git blame gave me your details. Thank you for editing the reviewer.
On 2016/06/12 16:44:31, tsimonq2 wrote: > Sorry, git blame gave me your details. Thank you for editing the reviewer. 'git blame AUTHORS' is not very informative. :-) What's critical in your CL is build/install-build-deps.sh for which you need an owner approval/review. Owners are listed in OWNERS file (start with a directory where the file you're modifying is and move up until you find OWNERS file).
lgtm
sorry for the delay, was ooo yesterday ...
Sorry for not getting to this for some time. Can you sign the CLA so we can land this? See https://cla.developers.google.com/.
I already signed it... Agreement Name Date Signed Manage Google Individual CLA Simon Quigley Jun 03, 2016 19:03 PDT Edit Contact Information
On 2016/09/01 02:41:03, tsimonq2 wrote: > I already signed it... > > Agreement Name Date Signed Manage > Google Individual CLA Simon Quigley Jun 03, 2016 19:03 PDT Edit Contact > Information Oh, sorry, I think I looked up your nickname rather than your email address. I've confirmed that you did in fact sign it.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2016/09/01 03:26:00, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Aha! Surely that's why I was confused ... :) At any rate, the email you added to AUTHORS needs to match the email you're uploading patches from.
I apologize for the delay here, but I'm not remembering how to add commits to this. I dislike using my Gmail address, but creating this account forced me to. Thanks for the review!
On 2016/10/10 03:38:09, tsimonq2 wrote: > I apologize for the delay here, but I'm not remembering how to add commits to > this. I dislike using my Gmail address, but creating this account forced me to. > > Thanks for the review! I'm sorry for all the process boilerplate :(. However, if you want to add tsimonq2@ubuntu.com to AUTHORS, I'm pretty sure that means you need to upload the patch from an account w/ the username tsimonq2@ubuntu.com. Or, change the email address in the AUTHORS entry to sqawesome99@gmail.com. The former actually requires a new CL, I think. You can do the latter by editing the file locally and then use `git-cl upload` again to upload the revised version.
The CQ bit was checked by sqawesome99@gmail.com
The CQ bit was unchecked by sqawesome99@gmail.com
On 2016/10/11 00:06:05, tsimonq2 wrote: > The CQ bit was unchecked by mailto:sqawesome99@gmail.com Whoops, wrong button.
Message was sent while issue was closed.
Closing, it looks like we never landed this but the support got added some other way. |
