Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2038983002: Use ContextUtils#getApplicationContext() instead of passing Context to ShortcutHelper (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
Peter Wen, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContextUtils#getApplicationContext() instead of passing Context to ShortcutHelper BUG=609122 Committed: https://crrev.com/45fc42b637f60767402eee89ad7498c1fb7ca94d Cr-Commit-Position: refs/heads/master@{#398159}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 1 8 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 6 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pkotwicz
Peter Wen, can you please take a look?
4 years, 6 months ago (2016-06-04 01:35:44 UTC) #2
Peter Wen
lgtm This is exactly why we created java-side ContextUtils.getApplicationContext. :)
4 years, 6 months ago (2016-06-06 12:33:42 UTC) #3
pkotwicz
dfalcantara@ for OWNERS
4 years, 6 months ago (2016-06-06 14:46:32 UTC) #5
gone
lgtm https://chromiumcodereview.appspot.com/2038983002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java (right): https://chromiumcodereview.appspot.com/2038983002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java#newcode385 chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:385: int blue) { fix indentation. int blue fits ...
4 years, 6 months ago (2016-06-06 18:13:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038983002/20001
4 years, 6 months ago (2016-06-06 22:22:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 00:08:35 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 00:11:41 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/45fc42b637f60767402eee89ad7498c1fb7ca94d
Cr-Commit-Position: refs/heads/master@{#398159}

Powered by Google App Engine
This is Rietveld 408576698