Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: chrome/browser/diagnostics/diagnostics_metrics.cc

Issue 2038933002: Drop diagnostics reference to out-dated database. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Oops, missed the by-name histograms that were in there. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/diagnostics/diagnostics_metrics.h" 5 #include "chrome/browser/diagnostics/diagnostics_metrics.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 30 matching lines...) Expand all
41 {"PathResources", "Resources path"}, 41 {"PathResources", "Resources path"},
42 {"PathUserData", "User data path"}, 42 {"PathUserData", "User data path"},
43 {"Version", "Chrome version test"}, 43 {"Version", "Chrome version test"},
44 {"SQLiteIntegrityAppCache", "Application cache database"}, 44 {"SQLiteIntegrityAppCache", "Application cache database"},
45 {"SQLiteIntegrityArchivedHistory", "Archived history database (obsolete)"}, 45 {"SQLiteIntegrityArchivedHistory", "Archived history database (obsolete)"},
46 {"SQLiteIntegrityCookie", "Cookie database"}, 46 {"SQLiteIntegrityCookie", "Cookie database"},
47 {"SQLiteIntegrityDatabaseTracker", "Database tracker database"}, 47 {"SQLiteIntegrityDatabaseTracker", "Database tracker database"},
48 {"SQLiteIntegrityHistory", "History database"}, 48 {"SQLiteIntegrityHistory", "History database"},
49 {"SQLiteIntegrityNSSCert", "NSS certificate database"}, 49 {"SQLiteIntegrityNSSCert", "NSS certificate database"},
50 {"SQLiteIntegrityNSSKey", "NSS Key database"}, 50 {"SQLiteIntegrityNSSKey", "NSS Key database"},
51 {"SQLiteIntegrityThumbnails", "Thumbnails database"}, 51 {"SQLiteIntegrityFavicons", "Favicons database"},
52 {"SQLiteIntegrityWebData", "Web Data database"}, 52 {"SQLiteIntegrityWebData", "Web Data database"},
53 {"SQLiteIntegrityTopSites", "Top Sites database"},
53 // Add new entries in the same order as DiagnosticsTestId. 54 // Add new entries in the same order as DiagnosticsTestId.
54 }; 55 };
55 56
56 static_assert(arraysize(kTestNameInfo) == DIAGNOSTICS_TEST_ID_COUNT, 57 static_assert(arraysize(kTestNameInfo) == DIAGNOSTICS_TEST_ID_COUNT,
57 "diagnostics test info mismatch"); 58 "diagnostics test info mismatch");
58 59
59 const TestNameInfo* FindTestInfo(DiagnosticsTestId id) { 60 const TestNameInfo* FindTestInfo(DiagnosticsTestId id) {
60 DCHECK(id < DIAGNOSTICS_TEST_ID_COUNT); 61 DCHECK(id < DIAGNOSTICS_TEST_ID_COUNT);
61 return &kTestNameInfo[id]; 62 return &kTestNameInfo[id];
62 } 63 }
(...skipping 30 matching lines...) Expand all
93 TEST_CASE(name, DIAGNOSTICS_PATH_RESOURCES_TEST); \ 94 TEST_CASE(name, DIAGNOSTICS_PATH_RESOURCES_TEST); \
94 TEST_CASE(name, DIAGNOSTICS_PATH_USER_DATA_TEST); \ 95 TEST_CASE(name, DIAGNOSTICS_PATH_USER_DATA_TEST); \
95 TEST_CASE(name, DIAGNOSTICS_VERSION_TEST); \ 96 TEST_CASE(name, DIAGNOSTICS_VERSION_TEST); \
96 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_APP_CACHE_TEST); \ 97 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_APP_CACHE_TEST); \
97 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_ARCHIVED_HISTORY_TEST_OBSOLETE);\ 98 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_ARCHIVED_HISTORY_TEST_OBSOLETE);\
98 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_COOKIE_TEST); \ 99 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_COOKIE_TEST); \
99 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_DATABASE_TRACKER_TEST); \ 100 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_DATABASE_TRACKER_TEST); \
100 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_HISTORY_TEST); \ 101 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_HISTORY_TEST); \
101 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_NSS_CERT_TEST); \ 102 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_NSS_CERT_TEST); \
102 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_NSS_KEY_TEST); \ 103 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_NSS_KEY_TEST); \
103 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_THUMBNAILS_TEST); \ 104 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_FAVICONS_TEST); \
104 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_WEB_DATA_TEST) 105 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_WEB_DATA_TEST); \
106 TEST_CASE(name, DIAGNOSTICS_SQLITE_INTEGRITY_TOPSITES_TEST);
105 107
106 void RecordUMARecoveryResult(DiagnosticsTestId id, RunResultMetrics result) { 108 void RecordUMARecoveryResult(DiagnosticsTestId id, RunResultMetrics result) {
107 const std::string name("Diagnostics.Recovery." + 109 const std::string name("Diagnostics.Recovery." +
108 GetTestName(static_cast<DiagnosticsTestId>(id))); 110 GetTestName(static_cast<DiagnosticsTestId>(id)));
109 switch (id) { 111 switch (id) {
110 TEST_CASES(name); // See above 112 TEST_CASES(name); // See above
111 default: 113 default:
112 NOTREACHED() << "Unhandled UMA Metric type" << id; 114 NOTREACHED() << "Unhandled UMA Metric type" << id;
113 } 115 }
114 } 116 }
115 117
116 void RecordUMATestResult(DiagnosticsTestId id, RunResultMetrics result) { 118 void RecordUMATestResult(DiagnosticsTestId id, RunResultMetrics result) {
117 const std::string name("Diagnostics.Test." + 119 const std::string name("Diagnostics.Test." +
118 GetTestName(static_cast<DiagnosticsTestId>(id))); 120 GetTestName(static_cast<DiagnosticsTestId>(id)));
119 switch (id) { 121 switch (id) {
120 TEST_CASES(name); // See above 122 TEST_CASES(name); // See above
121 default: 123 default:
122 NOTREACHED() << "Unhandled UMA Metric type" << id; 124 NOTREACHED() << "Unhandled UMA Metric type" << id;
123 } 125 }
124 } 126 }
125 #undef TEST_CASE 127 #undef TEST_CASE
126 #undef TEST_CASES 128 #undef TEST_CASES
127 129
128 } // namespace diagnostics 130 } // namespace diagnostics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698