Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2038893002: [Android] Add support for Partner bookmarks to Chrome bookmark widget (Closed)

Created:
4 years, 6 months ago by Ian Wen
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Android] Add support for Partner bookmarks to Chrome bookmark widget Before this CL, the current folder of the widget is stored as a long in the shared preferences. Now it will be stored as a String that can be serialized directly into a BookmarkId object. The advantage of storing strings is that it carries sufficient info about whether a bookmark is a partner bookmark. BUG=613171 Review-Url: https://codereview.chromium.org/2031893002 Cr-Commit-Position: refs/heads/master@{#397539} TBR=dfalcantara@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/6a93694b27f3711efa984b89b8b7b99167ba5cec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -27 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java View 8 chunks +14 lines, -28 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Ian Wen
4 years, 6 months ago (2016-06-03 17:34:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a93694b27f3711efa984b89b8b7b99167ba5cec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698