Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2038853003: Specialize Symbol.hashCode (Closed)

Created:
4 years, 6 months ago by sra1
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Specialize Symbol.hashCode Patch internal.Symbol.hashCode and specialize JS version to avoid recomputing String.hashCode R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b37747934e762dbb4973ddd8798c4ca6126f5f24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M runtime/lib/symbol_patch.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/internal_patch.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M sdk/lib/internal/symbol.dart View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
4 years, 6 months ago (2016-06-03 21:11:13 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 6 months ago (2016-06-03 21:15:57 UTC) #3
sra1
4 years, 6 months ago (2016-06-03 22:11:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b37747934e762dbb4973ddd8798c4ca6126f5f24 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698