Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2038813002: MIPS: Fix 'Turbofan: Modify WASM linkage to store floats using only 4 bytes.' (Closed)

Created:
4 years, 6 months ago by balazs.kilvady
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'Turbofan: Modify WASM linkage to store floats using only 4 bytes.' Port 817b59c8ad7e9237d93a43a31045285418bbb6d5 Adds instructions for MIPS to push float (single) and double registers. LOG=N BUG=v8:4124 TEST=cctest/test-run-native-calls/Float32Select_stack_params_return_reg, cctest/test-run-native-calls/MixedParams_0, cctest/test-run-native-calls/MixedParams_1, cctest/test-run-native-calls/MixedParams_2, cctest/test-run-native-calls/MixedParams_3 Committed: https://crrev.com/b9ded4ce9cda2053d084e043e8a30a90ae3e801d Cr-Commit-Position: refs/heads/master@{#36719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +7 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
balazs.kilvady
4 years, 6 months ago (2016-06-03 12:31:22 UTC) #3
bbudge
lgtm
4 years, 6 months ago (2016-06-03 13:10:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2038813002/1
4 years, 6 months ago (2016-06-03 16:17:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 16:43:12 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 16:44:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9ded4ce9cda2053d084e043e8a30a90ae3e801d
Cr-Commit-Position: refs/heads/master@{#36719}

Powered by Google App Engine
This is Rietveld 408576698