Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: chrome/browser/search/instant_unittest_base.h

Issue 20388003: Reload Instant NTP and Instant-process tabs on search url change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments, added a test to address the bug Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/instant_unittest_base.h
diff --git a/chrome/browser/search/instant_unittest_base.h b/chrome/browser/search/instant_unittest_base.h
new file mode 100644
index 0000000000000000000000000000000000000000..cb191f81d31a7f7f287a8de21bc75cb469f9933f
--- /dev/null
+++ b/chrome/browser/search/instant_unittest_base.h
@@ -0,0 +1,42 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SEARCH_INSTANT_UNITTEST_BASE_H_
+#define CHROME_BROWSER_SEARCH_INSTANT_UNITTEST_BASE_H_
+
+#include <string>
+
+#include "chrome/browser/search/instant_service.h"
+#include "chrome/browser/search_engines/template_url_service.h"
+#include "chrome/test/base/browser_with_test_window_test.h"
+
+// This class provides an extension on top of BrowserWithTestWindowTest, and
+// adds some utility methods which can be useful for various unit tests for
+// Embedded Search / Instant implementation classes.
+class InstantUnitTestBase : public BrowserWithTestWindowTest {
+ protected:
+ virtual void SetUp() OVERRIDE;
+ virtual void TearDown() OVERRIDE;
+
+ // Adds and sets the default search provider using the base_url.
+ // The base_url should have the http[s]:// prefix and a trailing / after the
+ // TLD.
+ // It will always use an instant-enabled configuration using a
+ // search_terms_replacement_key.
+ void SetSearchProvider(const std::string& base_url);
Jered 2013/08/16 00:13:23 Call this SetDefaultSearchProvider
Anuj 2013/08/22 00:40:45 Done.
+
+ // Simulates a Google Base URL change as would happen in event of
+ // search-domain-check. Note that the GoogleURLTrackerFactory is disabled for
+ // tests, so this is required.
+ void NotifyGoogleBaseURLUpdate(const std::string& new_google_base_url);
+
+ int NumObservers(InstantService* instant_service) {
Jered 2013/08/16 00:13:23 GetNumObservers
Anuj 2013/08/22 00:40:45 Done.
+ return instant_service->observers_.size();
+ }
+
+ InstantService* instant_service_;
+ TemplateURLService* template_url_service_;
+};
+
+#endif // CHROME_BROWSER_SEARCH_INSTANT_UNITTEST_BASE_H_

Powered by Google App Engine
This is Rietveld 408576698