Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2038793002: Clear media query rulesets on page zoom changes. (Closed)

Created:
4 years, 6 months ago by rune
Modified:
4 years, 6 months ago
Reviewers:
Yoav Weiss
CC:
chromium-reviews, blink-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear media query rulesets on page zoom changes. Otherwise, resolution media queries won't update properly when page zoom changes. Changing the deviceScaleFactor already did this. Also, matchMedia listeners already worked. BUG=617095 Committed: https://crrev.com/82a43d5e94ad2b873fa14f11a4c5f34c98863069 Cr-Commit-Position: refs/heads/master@{#397697}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use testharness.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/media/resolution-change-on-page-zoom.html View 1 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2038793002/1
4 years, 6 months ago (2016-06-03 09:44:12 UTC) #2
rune
PTAL
4 years, 6 months ago (2016-06-03 09:49:31 UTC) #5
Yoav Weiss
LGTM https://codereview.chromium.org/2038793002/diff/1/third_party/WebKit/LayoutTests/fast/media/resolution-change-on-page-zoom.html File third_party/WebKit/LayoutTests/fast/media/resolution-change-on-page-zoom.html (right): https://codereview.chromium.org/2038793002/diff/1/third_party/WebKit/LayoutTests/fast/media/resolution-change-on-page-zoom.html#newcode2 third_party/WebKit/LayoutTests/fast/media/resolution-change-on-page-zoom.html:2: <script src="../../resources/js-test.js"></script> Could you rewrite the test using ...
4 years, 6 months ago (2016-06-03 10:15:49 UTC) #6
rune
https://codereview.chromium.org/2038793002/diff/1/third_party/WebKit/LayoutTests/fast/media/resolution-change-on-page-zoom.html File third_party/WebKit/LayoutTests/fast/media/resolution-change-on-page-zoom.html (right): https://codereview.chromium.org/2038793002/diff/1/third_party/WebKit/LayoutTests/fast/media/resolution-change-on-page-zoom.html#newcode2 third_party/WebKit/LayoutTests/fast/media/resolution-change-on-page-zoom.html:2: <script src="../../resources/js-test.js"></script> On 2016/06/03 10:15:49, Yoav Weiss wrote: > ...
4 years, 6 months ago (2016-06-03 11:09:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2038793002/20001
4 years, 6 months ago (2016-06-03 11:32:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 13:23:36 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 13:24:43 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82a43d5e94ad2b873fa14f11a4c5f34c98863069
Cr-Commit-Position: refs/heads/master@{#397697}

Powered by Google App Engine
This is Rietveld 408576698