third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl - Issue 2038773002: [Typed OM] Add an "UnsupportedStyleValue" in C++ that just has a string for unknown types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl

Issue 2038773002: [Typed OM] Add an "UnsupportedStyleValue" in C++ that just has a string for unknown types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stylevaue

Patch Set: Don't store the CSSPropertyID in the UnsupportedStyleValue Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/typedcssom/inlinestyle/unsupported-properties.html ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl

index 7386654952c92094afec682f428b54b31a8c073f..a0b795128cc570ff0868c31a421ecb7e6b04b4ea 100644

--- a/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl

@@ -21,6 +21,9 @@ bool CSSOMTypes::propertyCanTake(CSSPropertyID id, const CSSStyleValue& styleVal

} else if (styleValue.type() == CSSStyleValue::KeywordType) {

// Keywords are also handled differently.

return CSSOMKeywords::validKeywordForProperty(id, toCSSKeywordValue(styleValue));

+ } else if (styleValue.type() == CSSStyleValue::Unknown) {

+ // The check has to happen later in this case.

Timothy Loh 2016/06/09 07:22:24 has to happen -> happens? Seems to me like we coul

meade_UTC10 2016/06/09 07:50:53 Done.

+ return true;

}

switch (id) {