chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java - Issue 2038753004: Add a LocationUtils class to give all Chromium Android code access to location helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

Issue 2038753004: Add a LocationUtils class to give all Chromium Android code access to location helpers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Use LOCATION_MODE instead of isProviderEnabled. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java » ('j') | components/location/OWNERS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

index c5d28e68d75d8c8ee86dfd355264b6349ff7a14c..411a830d56046dc9369e61faad454ef25c9c65c8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

@@ -19,6 +19,7 @@ import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.NativePage;

import org.chromium.chrome.browser.UrlConstants;

+import org.chromium.components.location.LocationUtils;

import java.util.HashSet;

import java.util.Set;

@@ -100,8 +101,9 @@ public class PhysicalWebDiagnosticsPage implements NativePage {

boolean isSdkVersionCorrect = isSdkVersionCorrect();

boolean isDataConnectionActive = Utils.isDataConnectionActive(mContext);

int bluetoothStatus = Utils.getBluetoothEnabledStatus(mContext);

- boolean isLocationServicesEnabled = Utils.isLocationServicesEnabled(mContext);

- boolean isLocationPermissionGranted = Utils.isLocationPermissionGranted(mContext);

+ LocationUtils locationUtils = LocationUtils.getInstance();

+ boolean isLocationServicesEnabled = locationUtils.isSystemLocationSettingEnabled(mContext);

+ boolean isLocationPermissionGranted = locationUtils.chromiumHasLocationPermission(mContext);

boolean isPreferenceEnabled = PhysicalWeb.isPhysicalWebPreferenceEnabled(mContext);

boolean isOnboarding = PhysicalWeb.isOnboarding(mContext);