device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java - Issue 2038753004: Add a LocationUtils class to give all Chromium Android code access to location helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java

Issue 2038753004: Add a LocationUtils class to give all Chromium Android code access to location helpers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Replace setInstanceForTesting with uses of setFactory. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/location/android/java/src/org/chromium/components/location/LocationUtils.java ('K') | « device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java ('k') | device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java

diff --git a/device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java b/device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java

index 2cc705d22253d5a993bd2581f333c082b6478d4f..76610108ba96a50c8d72044d5fd74ad8e2bae0ca 100644

--- a/device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java

+++ b/device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java

@@ -25,11 +25,11 @@ import android.content.IntentFilter;

import android.content.pm.PackageManager;

import android.os.Build;

import android.os.ParcelUuid;

-import android.os.Process;

import org.chromium.base.Log;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

+import org.chromium.components.location.LocationUtils;

import java.util.ArrayList;

import java.util.HashMap;

@@ -162,9 +162,8 @@ class Wrappers {

mContext = context;

}

- public boolean checkPermission(String permission) {

- return mContext.checkPermission(permission, Process.myPid(), Process.myUid())

- == PackageManager.PERMISSION_GRANTED;

+ public boolean chromeHasLocationPermission() {

+ return LocationUtils.getInstance().chromiumHasLocationPermission(mContext);

}

public Intent registerReceiver(BroadcastReceiver receiver, IntentFilter filter) {