Add a LocationUtils class to give all Chromium Android code access to location helpers.

device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.device.bluetooth;
 
 import android.Manifest;
 import android.annotation.TargetApi;
 import android.bluetooth.BluetoothAdapter;
 import android.bluetooth.BluetoothDevice;
 import android.bluetooth.BluetoothGatt;
 import android.bluetooth.BluetoothGattCallback;
 import android.bluetooth.BluetoothGattCharacteristic;
 import android.bluetooth.BluetoothGattDescriptor;
 import android.bluetooth.BluetoothGattService;
 import android.bluetooth.le.BluetoothLeScanner;
 import android.bluetooth.le.ScanCallback;
 import android.bluetooth.le.ScanFilter;
 import android.bluetooth.le.ScanResult;
 import android.bluetooth.le.ScanSettings;
 import android.content.BroadcastReceiver;
 import android.content.Context;
 import android.content.Intent;
 import android.content.IntentFilter;
 import android.content.pm.PackageManager;
 import android.os.Build;
 import android.os.ParcelUuid;
-import android.os.Process;
 
 import org.chromium.base.Log;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.annotations.JNINamespace;
+import org.chromium.components.location.LocationUtils;
 
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.UUID;
 
 /**
  * Wrapper classes around android.bluetooth.* classes that provide an
  * indirection layer enabling fake implementations when running tests.
  *
@@ skipping 112 matching lines @@
     /**
      * Wraps android.content.Context.
      */
     static class ContextWrapper {
         private final Context mContext;
 
         public ContextWrapper(Context context) {
             mContext = context;
         }
 
-        public boolean checkPermission(String permission) {
-            return mContext.checkPermission(permission, Process.myPid(), Process.myUid())
-                    == PackageManager.PERMISSION_GRANTED;
+        public boolean hasAndroidLocationPermission() {

[scheib, 2016/06/22 19:36:50]

The wrappers were designed to be the thinnest practical wrapper around the
Android classes. There are one or two examples of deviation (e.g.
getBluetoothClass_getDeviceClass), but they represent an API call and then
another call on the returned object.

This change adds a new concept to the wrapper that the android class doesn't
have, which I don't like. I see two main options:

1) Access LocationUtils.getInstance() and have test code able to set expected
behavior for it in test executables.

2) Sticking with this wrapper design, reworking as such:

To get virtual abstraction the wrappers need to be via a passed instance of an
object that is constructed elsewhere from code that knows if the executable is
production or test. Right now it is the adapter wrapper that is passed in to
ChromeBluetoothAdapter.java's constructor.

LocationUtils is a concept outside of the Adapter hierarchy, so we need a
wrapper for it passed in somehow.

A solution is to pass to ChromeBluetoothAdapter a new thing we create
'device.Wrappers' instance. That instance would have members for an
BluetoothAdapterWrapper and LocationUtilsWrapper.

[ortuno, 2016/06/27 21:05:53]

Follow up patch here: http://crrev.com/2100313003

Adds a new test function that uses LocationUtils.setFactory to control
LocationUtils from tests. LocationUtils still requires a Context. For that, the
patch removes ContextWrapper from Wrappers and modifies FakeContext to extend
MockContext. We can then pass the mock context directly to LocationUtils.

+            return LocationUtils.getInstance().hasAndroidLocationPermission(mContext);
         }
 
         public Intent registerReceiver(BroadcastReceiver receiver, IntentFilter filter) {
             return mContext.registerReceiver(receiver, filter);
         }
 
         public void unregisterReceiver(BroadcastReceiver receiver) {
             mContext.unregisterReceiver(receiver);
         }
     }
@@ skipping 402 matching lines @@
 
         public byte[] getValue() {
             return mDescriptor.getValue();
         }
 
         public boolean setValue(byte[] value) {
             return mDescriptor.setValue(value);
         }
     }
 }