Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: tools/gn/variables.cc

Issue 2038733003: 💹 Update GN docs about target_cpu to encourage use of current_cpu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change target_cpu example Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/docs/cross_compiles.md ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/variables.cc
diff --git a/tools/gn/variables.cc b/tools/gn/variables.cc
index 0eb5aabcf62448438bda02ca2c06cc559e5a95e6..8bafb68b02f33b0149465abdc3d55776b4c9a2c6 100644
--- a/tools/gn/variables.cc
+++ b/tools/gn/variables.cc
@@ -52,13 +52,13 @@ const char kTargetCpu_Help[] =
"\n"
" This value should be used to indicate the desired architecture for\n"
" the primary objects of the build. It will match the cpu architecture\n"
- " of the default toolchain.\n"
+ " of the default toolchain, but not necessarily the current toolchain.\n"
"\n"
" In many cases, this is the same as \"host_cpu\", but in the case\n"
- " of cross-compiles, this can be set to something different. This \n"
- " value is different from \"current_cpu\" in that it can be referenced\n"
- " from inside any toolchain. This value can also be ignored if it is\n"
- " not needed or meaningful for a project.\n"
+ " of cross-compiles, this can be set to something different. This\n"
+ " value is different from \"current_cpu\" in that it does not change\n"
+ " based on the current toolchain. When writing rules, \"current_cpu\"\n"
+ " should be used rather than \"target_cpu\" most of the time.\n"
"\n"
" This value is not used internally by GN for any purpose, so it\n"
" may be set to whatever value is needed for the build.\n"
« no previous file with comments | « tools/gn/docs/cross_compiles.md ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698