third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.cpp - Issue 2038573002: [Android, RemotePlayback] Make RemotePlayback classes ActiveScriptWrappable's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.cpp

Issue 2038573002: [Android, RemotePlayback] Make RemotePlayback classes ActiveScriptWrappable's (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't observe execution context, just return the element's document. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.h ('k') | third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.cpp

diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.cpp b/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.cpp

index 11bbb49c77cc13ac8c68a098b6f671e3454ee697..96562a610c51e2d834b814fdd3945b4a6fc6f681 100644

--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.cpp

+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.cpp

@@ -18,7 +18,8 @@ RemotePlaybackAvailability* RemotePlaybackAvailability::take(ScriptPromiseResolv

}

RemotePlaybackAvailability::RemotePlaybackAvailability(ExecutionContext* executionContext, bool value)

- : ContextLifecycleObserver(executionContext)

+ : ActiveScriptWrappable(this)

+ , ContextLifecycleObserver(executionContext)

, m_value(value)

{

ASSERT(executionContext->isDocument());

@@ -50,6 +51,11 @@ bool RemotePlaybackAvailability::value() const

return m_value;

}

+bool RemotePlaybackAvailability::hasPendingActivity() const

+ return hasEventListeners();

DEFINE_TRACE(RemotePlaybackAvailability)

{

EventTargetWithInlineData::trace(visitor);