Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h

Issue 2038573002: [Android, RemotePlayback] Make RemotePlayback classes ActiveScriptWrappable's (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed RemotePlayback to be ContextLifecycleObserver Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
index 0458704dab21fea73bcfa3dfff6512fc2d51770e..54978fdb7d61b17916ccddb9e0d5f68db30c4ac7 100644
--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
@@ -5,9 +5,10 @@
#ifndef RemotePlayback_h
#define RemotePlayback_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptPromise.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/events/EventTarget.h"
-#include "core/frame/DOMWindowProperty.h"
#include "platform/heap/Handle.h"
#include "public/platform/modules/remoteplayback/WebRemotePlaybackClient.h"
#include "public/platform/modules/remoteplayback/WebRemotePlaybackState.h"
@@ -24,7 +25,8 @@ class ScriptPromiseResolver;
class RemotePlayback final
: public EventTargetWithInlineData
- , public DOMWindowProperty
+ , public ActiveScriptWrappable
+ , public ContextLifecycleObserver
, private WebRemotePlaybackClient {
DEFINE_WRAPPERTYPEINFO();
USING_GARBAGE_COLLECTED_MIXIN(RemotePlayback);
@@ -40,6 +42,9 @@ public:
String state() const;
+ // ActiveScriptWrappable implementation.
+ bool hasPendingActivity() const final;
+
DEFINE_ATTRIBUTE_EVENT_LISTENER(statechange);
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698