Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2038563003: [builtins] Migrate StringFromCodePoint to C++. (Closed)

Created:
4 years, 6 months ago by Franzi
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate StringFromCodePoint to C++. Instead of a JS implementation that calls C++ runtime functions, migrate String.fromCodePoint() to C++. BUG=v8:5049 Committed: https://crrev.com/e89d8b6a76d1219e4e42f0e821084ba6d53c1bfa Cr-Commit-Position: refs/heads/master@{#37293}

Patch Set 1 #

Patch Set 2 : Throw correct error message when codePoint is a symbol #

Patch Set 3 : Refactor #

Patch Set 4 : Delete dummy testcases #

Patch Set 5 : Initialize variable to make compiler happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -29 lines) Patch
M src/bootstrapper.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 2 3 4 2 chunks +94 lines, -1 line 0 comments Download
M src/js/string.js View 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Franzi
Hi Benedikt, I moved String.fromCodePoint() to builtins. Any chance you're working on StringIteratorNext() so we ...
4 years, 5 months ago (2016-06-27 13:13:35 UTC) #4
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-06-27 13:23:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2038563003/80001
4 years, 5 months ago (2016-06-27 13:23:40 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-06-27 13:47:44 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 13:49:32 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e89d8b6a76d1219e4e42f0e821084ba6d53c1bfa
Cr-Commit-Position: refs/heads/master@{#37293}

Powered by Google App Engine
This is Rietveld 408576698