Merge weburlrequest_extradata_impl.cc/h into content/child/request_extra_data.cc/h (attempt #2)

content/renderer/render_frame_impl.cc

Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 1365a3818a4beab692f4fe82bb198b40972e61e3..b7f89aa633ad746b929f4f49d2abe96df332f979 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -145,8 +145,7 @@ int64 ExtractPostId(const WebHistoryItem& item) {
 
 WebURLResponseExtraDataImpl* GetExtraDataFromResponse(
     const WebURLResponse& response) {
-  return static_cast<WebURLResponseExtraDataImpl*>(
-      response.extraData());
+  return static_cast<WebURLResponseExtraDataImpl*>(response.extraData());
 }
 
 void GetRedirectChain(WebDataSource* ds, std::vector<GURL>* result) {
@@ -1824,8 +1823,10 @@ void RenderFrameImpl::willRequestAfterPreconnect(
   bool was_after_preconnect_request = true;
   // The args after |was_after_preconnect_request| are not used, and set to
   // correct values at |willSendRequest|.
-  request.setExtraData(new webkit_glue::WebURLRequestExtraDataImpl(
-      custom_user_agent, was_after_preconnect_request));
+  RequestExtraData* extra_data = new RequestExtraData();
+  extra_data->set_custom_user_agent(custom_user_agent);
+  extra_data->set_was_after_preconnect_request(was_after_preconnect_request);
+  request.setExtraData(extra_data);
 }
 
 void RenderFrameImpl::willSendRequest(
@@ -1874,8 +1875,8 @@ void RenderFrameImpl::willSendRequest(
   WebString custom_user_agent;
   bool was_after_preconnect_request = false;
   if (request.extraData()) {
-    webkit_glue::WebURLRequestExtraDataImpl* old_extra_data =
-        static_cast<webkit_glue::WebURLRequestExtraDataImpl*>(
+    RequestExtraData* old_extra_data =
+        static_cast<RequestExtraData*>(
             request.extraData());
     custom_user_agent = old_extra_data->custom_user_agent();
     was_after_preconnect_request =
@@ -1925,21 +1926,25 @@ void RenderFrameImpl::willSendRequest(
 
   int parent_routing_id = frame->parent() ?
       FromWebFrame(frame->parent())->GetRoutingID() : -1;
-  request.setExtraData(
-      new RequestExtraData(render_view_->visibilityState(),
-                           custom_user_agent,
-                           was_after_preconnect_request,
-                           routing_id_,
-                           (frame == top_frame),
-                           GURL(frame->document().securityOrigin().toString()),
-                           frame->parent() == top_frame,
-                           parent_routing_id,
-                           navigation_state->allow_download(),
-                           transition_type,
-                           should_replace_current_entry,
-                           navigation_state->transferred_request_child_id(),
-                           navigation_state->transferred_request_request_id(),
-                           provider_id));
+  RequestExtraData extra_data;

[michaeln, 2014/03/20 00:10:43]

whoa... this is stack allocated shouldn't this be heap alloced? what am i
missing?

    // Extra data associated with the underlying resource request. Resource
    // requests can be copied. If non-null, each copy of a resource requests
    // holds a pointer to the extra data, and the extra data pointer will be
    // deleted when the last resource request is destroyed. Setting the extra
    // data pointer will cause the underlying resource request to be
    // dissociated from any existing non-null extra data pointer.
    BLINK_PLATFORM_EXPORT ExtraData* extraData() const;
    BLINK_PLATFORM_EXPORT void setExtraData(ExtraData*);

[michaeln, 2014/03/20 00:48:25]

Let me rephrase that, its not really a question.

Please heap allocate the extra_data here since ownership of the ptr is passed to
the blink::WebURLRequest below. And keep as stack allocs in
plugin_url_fetcher.cc and resource_dispatcher_unittest.cc (which do not pass
ownership to WebURLRequest).

+  extra_data.set_visibility_state(render_view_->visibilityState());
+  extra_data.set_custom_user_agent(custom_user_agent);
+  extra_data.set_was_after_preconnect_request(was_after_preconnect_request);
+  extra_data.set_render_frame_id(routing_id_);
+  extra_data.set_is_main_frame(frame == top_frame);
+  extra_data.set_frame_origin(
+      GURL(frame->document().securityOrigin().toString()));
+  extra_data.set_parent_is_main_frame(frame->parent() == top_frame);
+  extra_data.set_parent_render_frame_id(parent_routing_id);
+  extra_data.set_allow_download(navigation_state->allow_download());
+  extra_data.set_transition_type(transition_type);
+  extra_data.set_should_replace_current_entry(should_replace_current_entry);
+  extra_data.set_transferred_request_child_id(
+      navigation_state->transferred_request_child_id());
+  extra_data.set_transferred_request_request_id(
+      navigation_state->transferred_request_request_id());
+  extra_data.set_service_worker_provider_id(provider_id);
+  request.setExtraData(&extra_data);
 
   DocumentState* top_document_state =
       DocumentState::FromDataSource(top_data_source);
@@ -2004,7 +2009,8 @@ void RenderFrameImpl::didReceiveResponse(
   int http_status_code = response.httpStatusCode();
 
   // Record page load flags.
-  WebURLResponseExtraDataImpl* extra_data = GetExtraDataFromResponse(response);
+  WebURLResponseExtraDataImpl* extra_data =
+      GetExtraDataFromResponse(response);
   if (extra_data) {
     document_state->set_was_fetched_via_spdy(
         extra_data->was_fetched_via_spdy());