Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1978)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 203853003: Merge weburlrequest_extradata_impl.cc/h into content/child/request_extra_data.cc/h (attempt #2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/url_request_info_util.cc ('k') | webkit/child/webkit_child.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 119683577dabc2d6482e361a5a673cc8cf9a6d4a..970dc4d2d4a5e380368ca439b63073d0f23b6a6d 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -152,8 +152,7 @@ int64 ExtractPostId(const WebHistoryItem& item) {
WebURLResponseExtraDataImpl* GetExtraDataFromResponse(
const WebURLResponse& response) {
- return static_cast<WebURLResponseExtraDataImpl*>(
- response.extraData());
+ return static_cast<WebURLResponseExtraDataImpl*>(response.extraData());
}
void GetRedirectChain(WebDataSource* ds, std::vector<GURL>* result) {
@@ -1923,8 +1922,10 @@ void RenderFrameImpl::willRequestAfterPreconnect(
bool was_after_preconnect_request = true;
// The args after |was_after_preconnect_request| are not used, and set to
// correct values at |willSendRequest|.
- request.setExtraData(new webkit_glue::WebURLRequestExtraDataImpl(
- custom_user_agent, was_after_preconnect_request));
+ RequestExtraData* extra_data = new RequestExtraData();
+ extra_data->set_custom_user_agent(custom_user_agent);
+ extra_data->set_was_after_preconnect_request(was_after_preconnect_request);
+ request.setExtraData(extra_data);
}
void RenderFrameImpl::willSendRequest(
@@ -1973,8 +1974,8 @@ void RenderFrameImpl::willSendRequest(
WebString custom_user_agent;
bool was_after_preconnect_request = false;
if (request.extraData()) {
- webkit_glue::WebURLRequestExtraDataImpl* old_extra_data =
- static_cast<webkit_glue::WebURLRequestExtraDataImpl*>(
+ RequestExtraData* old_extra_data =
+ static_cast<RequestExtraData*>(
request.extraData());
custom_user_agent = old_extra_data->custom_user_agent();
was_after_preconnect_request =
@@ -2024,21 +2025,25 @@ void RenderFrameImpl::willSendRequest(
int parent_routing_id = frame->parent() ?
FromWebFrame(frame->parent())->GetRoutingID() : -1;
- request.setExtraData(
- new RequestExtraData(render_view_->visibilityState(),
- custom_user_agent,
- was_after_preconnect_request,
- routing_id_,
- (frame == top_frame),
- GURL(frame->document().securityOrigin().toString()),
- frame->parent() == top_frame,
- parent_routing_id,
- navigation_state->allow_download(),
- transition_type,
- should_replace_current_entry,
- navigation_state->transferred_request_child_id(),
- navigation_state->transferred_request_request_id(),
- provider_id));
+ RequestExtraData* extra_data = new RequestExtraData();
+ extra_data->set_visibility_state(render_view_->visibilityState());
+ extra_data->set_custom_user_agent(custom_user_agent);
+ extra_data->set_was_after_preconnect_request(was_after_preconnect_request);
+ extra_data->set_render_frame_id(routing_id_);
+ extra_data->set_is_main_frame(frame == top_frame);
+ extra_data->set_frame_origin(
+ GURL(frame->document().securityOrigin().toString()));
+ extra_data->set_parent_is_main_frame(frame->parent() == top_frame);
+ extra_data->set_parent_render_frame_id(parent_routing_id);
+ extra_data->set_allow_download(navigation_state->allow_download());
+ extra_data->set_transition_type(transition_type);
+ extra_data->set_should_replace_current_entry(should_replace_current_entry);
+ extra_data->set_transferred_request_child_id(
+ navigation_state->transferred_request_child_id());
+ extra_data->set_transferred_request_request_id(
+ navigation_state->transferred_request_request_id());
+ extra_data->set_service_worker_provider_id(provider_id);
+ request.setExtraData(extra_data);
DocumentState* top_document_state =
DocumentState::FromDataSource(top_data_source);
@@ -2103,7 +2108,8 @@ void RenderFrameImpl::didReceiveResponse(
int http_status_code = response.httpStatusCode();
// Record page load flags.
- WebURLResponseExtraDataImpl* extra_data = GetExtraDataFromResponse(response);
+ WebURLResponseExtraDataImpl* extra_data =
+ GetExtraDataFromResponse(response);
if (extra_data) {
document_state->set_was_fetched_via_spdy(
extra_data->was_fetched_via_spdy());
« no previous file with comments | « content/renderer/pepper/url_request_info_util.cc ('k') | webkit/child/webkit_child.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698