Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/mb/mb.py

Issue 2038483002: mb: Allow overriding the path to the gyp script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/mb/docs/user_guide.md ('K') | « tools/mb/docs/user_guide.md ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb.py
diff --git a/tools/mb/mb.py b/tools/mb/mb.py
index 2c16266c641b09fcb0b12c41863af082a377914f..5421e231284085e4227ab82a3fc2fc99d51f30b4 100755
--- a/tools/mb/mb.py
+++ b/tools/mb/mb.py
@@ -84,6 +84,9 @@ class MetaBuildWrapper(object):
'(default is //tools/mb/mb_config.pyl)')
subp.add_argument('-g', '--goma-dir',
help='path to goma directory')
+ subp.add_argument('--gyp-script',
Michael Achenbach 2016/06/03 07:36:38 FYI: I didn't specify a default here to keep the t
Dirk Pranke 2016/06/03 17:59:24 I don't quite understand this comment; PathJoin()
Michael Achenbach 2016/06/03 19:55:03 That's what I tried. PathJoin was not defined in t
+ help='path to gyp script relative to project root '
+ '(default is build/gyp_chromium)')
subp.add_argument('--android-version-code',
help='Sets GN arg android_default_version_code and '
'GYP_DEFINE app_manifest_version_code')
@@ -1105,7 +1108,7 @@ class MetaBuildWrapper(object):
cmd = [
self.executable,
- self.PathJoin('build', 'gyp_chromium'),
+ self.args.gyp_script or self.PathJoin('build', 'gyp_chromium'),
'-G',
'output_dir=' + output_dir,
]
« tools/mb/docs/user_guide.md ('K') | « tools/mb/docs/user_guide.md ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698