Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2038473002:
Specify direct dependency of //components/crash on kasko_features.h (Closed)
|
Created:
4 years, 6 months ago by blundell Modified:
4 years, 6 months ago CC:
chromium-reviews, sadrul, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, darin-cc_chromium.org, kalyank Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSpecify direct dependency of //components/crash on kasko_features.h
//components/crash/content/app has a public dependency on the generated
header kasko_features.h. However, the GYP and GN files specify this
dependency only transitively via a dependency on //third_party/kasko
(which //components/crash/content/app does not actually depend on). This
CL changes the dependency to be directly on
//third_party/kasko:kasko_features as a speculative fix for the build
failures listed in crbug.com/611319. Note that in any case this change
is correct (whether it ends up resolving the flaky build failures or no).
BUG=611319
TBR=pmonette
Committed: https://crrev.com/d507af25f7281161a3eb0d44a0deef057e46c8dc
Cr-Commit-Position: refs/heads/master@{#397390}
Patch Set 1 #
Messages
Total messages: 20 (8 generated)
blundell@chromium.org changed reviewers: + mark@chromium.org
Just for ENABLE_KASKO, right? LGTM.
On 2016/06/02 13:22:17, Mark Mentovai wrote: > Just for ENABLE_KASKO, right? LGTM. Exactly.
The CQ bit was checked by blundell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2038473002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Specify direct dependency of //components/crash on kasko_features.h //components/crash/content/app has a public dependency on the generated header kasko_features.h. However, the GYP and GN files specify this dependency only transitively via a dependency on //third_party/kasko (which //components/crash/content/app does not actually depend on). This CL changes the dependency to be directly on //third_party/kasko:kasko_features as a speculative fix for the build failures listed in crbug.com/611319. Note that in any case this change is correct (whether it ends up resolving the flaky build failures or no). BUG=611319 ========== to ========== Specify direct dependency of //components/crash on kasko_features.h //components/crash/content/app has a public dependency on the generated header kasko_features.h. However, the GYP and GN files specify this dependency only transitively via a dependency on //third_party/kasko (which //components/crash/content/app does not actually depend on). This CL changes the dependency to be directly on //third_party/kasko:kasko_features as a speculative fix for the build failures listed in crbug.com/611319. Note that in any case this change is correct (whether it ends up resolving the flaky build failures or no). BUG=611319 TBR=pmonette ==========
blundell@chromium.org changed reviewers: + pmonette@chromium.org
TBR=pmonette for the change in //components/crash/content/app/DEPS, as it's actually just a restriction on the existing dependency on //third_party/kasko.
The CQ bit was checked by blundell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2038473002/1
Message was sent while issue was closed.
Description was changed from ========== Specify direct dependency of //components/crash on kasko_features.h //components/crash/content/app has a public dependency on the generated header kasko_features.h. However, the GYP and GN files specify this dependency only transitively via a dependency on //third_party/kasko (which //components/crash/content/app does not actually depend on). This CL changes the dependency to be directly on //third_party/kasko:kasko_features as a speculative fix for the build failures listed in crbug.com/611319. Note that in any case this change is correct (whether it ends up resolving the flaky build failures or no). BUG=611319 TBR=pmonette ========== to ========== Specify direct dependency of //components/crash on kasko_features.h //components/crash/content/app has a public dependency on the generated header kasko_features.h. However, the GYP and GN files specify this dependency only transitively via a dependency on //third_party/kasko (which //components/crash/content/app does not actually depend on). This CL changes the dependency to be directly on //third_party/kasko:kasko_features as a speculative fix for the build failures listed in crbug.com/611319. Note that in any case this change is correct (whether it ends up resolving the flaky build failures or no). BUG=611319 TBR=pmonette ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Specify direct dependency of //components/crash on kasko_features.h //components/crash/content/app has a public dependency on the generated header kasko_features.h. However, the GYP and GN files specify this dependency only transitively via a dependency on //third_party/kasko (which //components/crash/content/app does not actually depend on). This CL changes the dependency to be directly on //third_party/kasko:kasko_features as a speculative fix for the build failures listed in crbug.com/611319. Note that in any case this change is correct (whether it ends up resolving the flaky build failures or no). BUG=611319 TBR=pmonette ========== to ========== Specify direct dependency of //components/crash on kasko_features.h //components/crash/content/app has a public dependency on the generated header kasko_features.h. However, the GYP and GN files specify this dependency only transitively via a dependency on //third_party/kasko (which //components/crash/content/app does not actually depend on). This CL changes the dependency to be directly on //third_party/kasko:kasko_features as a speculative fix for the build failures listed in crbug.com/611319. Note that in any case this change is correct (whether it ends up resolving the flaky build failures or no). BUG=611319 TBR=pmonette Committed: https://crrev.com/d507af25f7281161a3eb0d44a0deef057e46c8dc Cr-Commit-Position: refs/heads/master@{#397390} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d507af25f7281161a3eb0d44a0deef057e46c8dc Cr-Commit-Position: refs/heads/master@{#397390}
Message was sent while issue was closed.
On 2016/06/02 14:04:07, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/d507af25f7281161a3eb0d44a0deef057e46c8dc > Cr-Commit-Position: refs/heads/master@{#397390} https://build.chromium.org/p/chromium/builders/Win/builds/44040/steps/compile... shows: [5167/33845] CXX obj\chrome\installer\setup\setup_lib.installer_crash_reporting.obj FAILED: obj/chrome/installer/setup/setup_lib.installer_crash_reporting.obj ninja -t msvc -e environment.x86 -- C:\b\build\slave\cache\cipd\goma/gomacc "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\setup\setup_lib.installer_crash_reporting.obj.rsp /c ..\..\chrome\installer\setup\installer_crash_reporting.cc /Foobj\chrome\installer\setup\setup_lib.installer_crash_reporting.obj /Fdobj\chrome\setup_lib.cc.pdb c:\b\build\slave\win\build\src\components\crash\content\app\crashpad.h(15): fatal error C1083: Cannot open include file: 'third_party/kasko/kasko_features.h': No such file or directory I have no idea how this is related, but it seems related. Unfortunately I don't have time just now to debug things, just dropping an FYI, and I'll update the status.
Message was sent while issue was closed.
On 2016/06/05 03:08:47, Scott Hess wrote: > On 2016/06/02 14:04:07, commit-bot: I haz the power wrote: > > Patchset 1 (id:??) landed as > > https://crrev.com/d507af25f7281161a3eb0d44a0deef057e46c8dc > > Cr-Commit-Position: refs/heads/master@{#397390} > > https://build.chromium.org/p/chromium/builders/Win/builds/44040/steps/compile... > shows: > [5167/33845] CXX > obj\chrome\installer\setup\setup_lib.installer_crash_reporting.obj > FAILED: obj/chrome/installer/setup/setup_lib.installer_crash_reporting.obj > ninja -t msvc -e environment.x86 -- C:\b\build\slave\cache\cipd\goma/gomacc > "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86\cl.exe" > /nologo /showIncludes /FC > @obj\chrome\installer\setup\setup_lib.installer_crash_reporting.obj.rsp /c > ..\..\chrome\installer\setup\installer_crash_reporting.cc > /Foobj\chrome\installer\setup\setup_lib.installer_crash_reporting.obj > /Fdobj\chrome\setup_lib.cc.pdb > c:\b\build\slave\win\build\src\components\crash\content\app\crashpad.h(15): > fatal error C1083: Cannot open include file: > 'third_party/kasko/kasko_features.h': No such file or directory > > I have no idea how this is related, but it seems related. Unfortunately I don't > have time just now to debug things, just dropping an FYI, and I'll update the > status. http://crbug.com/617434
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2047473002/ by sebmarchand@chromium.org. The reason for reverting is: It's breaking the official win-asan builder (https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/bui...). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
