Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2038463004: Remove references to network_hints::UrlList and network_hints::NameList (Closed)

Created:
4 years, 6 months ago by Charlie Harrison
Modified:
4 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to network_hints::UrlList and network_hints::NameList This patch removes typedefs from network_hints, in preparation on its removal (in favor of mojo IPC from Blink to content). BUG=610750 Committed: https://crrev.com/b4c497067ca404764c5d67df607e894d3118bfae Cr-Commit-Position: refs/heads/master@{#397467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M chrome/browser/net/predictor.h View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/net/predictor.cc View 6 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/net/predictor_browsertest.cc View 6 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Charlie Harrison
Eric, mind taking a look at this fairly trivial search and replace CL? I'll have ...
4 years, 6 months ago (2016-06-02 16:04:09 UTC) #3
eroman
lgtm
4 years, 6 months ago (2016-06-02 16:38:55 UTC) #4
Charlie Harrison
On 2016/06/02 16:38:55, eroman wrote: > lgtm Thanks!
4 years, 6 months ago (2016-06-02 17:55:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2038463004/1
4 years, 6 months ago (2016-06-02 17:55:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 18:00:57 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 18:02:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4c497067ca404764c5d67df607e894d3118bfae
Cr-Commit-Position: refs/heads/master@{#397467}

Powered by Google App Engine
This is Rietveld 408576698