Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2038463002: Revert of Move (hopefully) remaining isolate related variables to toolchain.gypi (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
Michael Achenbach, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Move (hopefully) remaining isolate related variables to toolchain.gypi (patchset #1 id:1 of https://codereview.chromium.org/2027213002/ ) Reason for revert: Fails: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7182/steps/gclient%20runhooks/logs/stdio Original issue's description: > Move (hopefully) remaining isolate related variables to toolchain.gypi > > BUG=chromium:609107 > R=machenbach@chromium.org > > Committed: https://crrev.com/a68a1eb38dda0a1eba3b7644a172d2f85e9c7abe > Cr-Commit-Position: refs/heads/master@{#36664} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:609107 Committed: https://crrev.com/dab67f0331c45d0379a65902215b995447d76684 Cr-Commit-Position: refs/heads/master@{#36665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M gypfiles/standalone.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M gypfiles/toolchain.gypi View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Move (hopefully) remaining isolate related variables to toolchain.gypi
4 years, 6 months ago (2016-06-02 07:10:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2038463002/1
4 years, 6 months ago (2016-06-02 07:10:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 07:10:29 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 07:10:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dab67f0331c45d0379a65902215b995447d76684
Cr-Commit-Position: refs/heads/master@{#36665}

Powered by Google App Engine
This is Rietveld 408576698