Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Issue 2038423002: Adding support for phone and email. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding support for phone and email. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
index a03a994d1650989f91bcb84c23facd2336107a3a..eebbcc9a4750fd2d8b7f67a9ab52d3cb6d2148a9 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
@@ -480,6 +480,30 @@ void PaymentRequest::OnPaymentResponse(mojom::blink::PaymentResponsePtr response
}
}
+ if (m_options.requestPayerEmail() && response->payer_email.isEmpty()) {
palmer 2016/06/16 21:23:34 Nit: This code is unnecessarily repetitive. Maybe
+ m_showResolver->reject(DOMException::create(SyntaxError));
+ clearResolversAndCloseMojoConnection();
+ return;
+ }
+
+ if (!m_options.requestPayerEmail() && !response->payer_email.isNull()) {
+ m_showResolver->reject(DOMException::create(SyntaxError));
+ clearResolversAndCloseMojoConnection();
+ return;
+ }
+
+ if (m_options.requestPayerPhone() && response->payer_phone.isEmpty()) {
+ m_showResolver->reject(DOMException::create(SyntaxError));
+ clearResolversAndCloseMojoConnection();
+ return;
+ }
+
+ if (!m_options.requestPayerPhone() && !response->payer_phone.isNull()) {
+ m_showResolver->reject(DOMException::create(SyntaxError));
+ clearResolversAndCloseMojoConnection();
+ return;
+ }
+
m_showResolver->resolve(new PaymentResponse(std::move(response), this));
// Do not close the mojo connection here. The merchant website should call

Powered by Google App Engine
This is Rietveld 408576698