Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

Issue 2038423002: Adding support for phone and email. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
index 66362d69ad24ad5e43b0193dec218e96b7c1646d..ea23f6e92a2ca1272e4fec892aaff766755ba745 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
@@ -15,6 +15,8 @@ PaymentResponse::PaymentResponse(mojom::blink::PaymentResponsePtr response, Paym
: m_methodName(response->method_name)
, m_stringifiedDetails(response->stringified_details)
, m_shippingAddress(response->shipping_address ? new PaymentAddress(std::move(response->shipping_address)) : nullptr)
+ , m_payerEmail(response->payer_email.isEmpty() ? String() : response->payer_email)
dcheng 2016/06/08 00:31:44 I'm kind of surprised there's no better way to do
dcheng 2016/06/08 00:37:53 Actually, I just talked to esprehn@ and he confirm
please use gerrit instead 2016/06/08 01:27:17 I think we can be simple: , m_payerEmail(response
yzshen1 2016/06/08 16:28:59 (sorry for late response.) Yes, that is already WT
+ , m_payerPhone(response->payer_phone.isEmpty() ? String() : response->payer_phone)
, m_paymentCompleter(paymentCompleter)
{
DCHECK(m_paymentCompleter);

Powered by Google App Engine
This is Rietveld 408576698