Adding support for phone and email.

third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentRequest.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/JSONValuesForV8.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
@@ skipping 457 matching lines @@
         m_shippingAddress = new PaymentAddress(response->shipping_address.Clone());
         m_shippingOption = response->shipping_option_id;
     } else {
         if (response->shipping_address) {
             m_showResolver->reject(DOMException::create(SyntaxError));
             clearResolversAndCloseMojoConnection();
             return;
         }
     }
 
+    if (m_options.requestPayerEmail() && response->payer_email.isEmpty()) {
+        m_showResolver->reject(DOMException::create(SyntaxError));
+        clearResolversAndCloseMojoConnection();
+        return;
+    }

[please use gerrit instead, 2016/06/10 17:46:51]

Let's follow the convention of the shipping address logic above. Add a clause
like this here and below:

else {
  if (!response->payer_email.isNull()) {
    m_showResolver->reject(DOMException::create(SyntaxError));
    clearResolversAndCloseMojoConnection();
    return;
  }
}

Then you test
ResolveShowPromiseWithRequestPayerPhoneFalseAndEmptyPayerPhoneInResponse should
be renamed into:

RejectShowPromiseWithRequestPayerPhoneFalseAndNonNullPayerPhoneInResponse

I changed "Resolve"->"Reject" and "Empty"->"NonNull".

In your test, you should check that show promise gets rejected. This is because,
if email was not requested, then a null email should be in response. Non-null
email should reject the show() promise.

+
+    if (m_options.requestPayerPhone() && response->payer_phone.isEmpty()) {
+        m_showResolver->reject(DOMException::create(SyntaxError));
+        clearResolversAndCloseMojoConnection();
+        return;
+    }
+
     m_showResolver->resolve(new PaymentResponse(std::move(response), this));
 
     // Do not close the mojo connection here. The merchant website should call
     // PaymentResponse::complete(boolean), which will be forwarded over the mojo
     // connection to display a success or failure message to the user.
     m_showResolver.clear();
 }
 
 void PaymentRequest::OnError()
 {
@@ skipping 14 matching lines @@
 void PaymentRequest::clearResolversAndCloseMojoConnection()
 {
     m_completeResolver.clear();
     m_showResolver.clear();
     if (m_clientBinding.is_bound())
         m_clientBinding.Close();
     m_paymentProvider.reset();
 }
 
 } // namespace blink