Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Issue 2038333002: PaymentRequest: Provide shippingAddress in PaymentResponse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
index b714ad694eba2cfa9da60da2279478a1c7819b21..a2c9d644a6302f2c76d1aab201436b217b763851 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
@@ -435,7 +435,11 @@ void PaymentRequest::OnPaymentResponse(mojom::blink::PaymentResponsePtr response
return;
}
- m_shippingAddress = new PaymentAddress(std::move(response->shipping_address));
+ if (m_options.requestShipping())
please use gerrit instead 2016/06/06 01:09:34 Replace this block with: m_shippingAddress = new
zino 2016/06/06 10:02:13 Done.
+ m_shippingAddress = new PaymentAddress(response->shipping_address->Clone());
+ else
+ m_shippingAddress = new PaymentAddress(std::move(response->shipping_address));
+
m_shippingOption = response->shipping_option_id;
}

Powered by Google App Engine
This is Rietveld 408576698