[interpreter] Filter expression positions at source.

test/cctest/interpreter/test-source-positions.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/compiler/pipeline.h"
 #include "src/handles.h"
 #include "src/interpreter/bytecode-generator.h"
 #include "src/interpreter/interpreter.h"
 #include "src/isolate.h"
 #include "src/parsing/parser.h"
 #include "test/cctest/cctest.h"
 #include "test/cctest/interpreter/source-position-matcher.h"
 
 namespace v8 {
 namespace internal {
 namespace interpreter {
 
 // Flags enabling optimizations that change generated bytecode array.
 // Format is <command-line flag> <flag name> <bit index>
-#define OPTIMIZATION_FLAGS(V)      \
-  V(FLAG_ignition_reo, kUseReo, 0) \
-  V(FLAG_ignition_peephole, kUsePeephole, 1)
+#define OPTIMIZATION_FLAGS(V)                \
+  V(FLAG_ignition_reo, kUseReo, 0)           \
+  V(FLAG_ignition_peephole, kUsePeephole, 1) \
+  V(FLAG_ignition_filter_positions, kUsePositionFiltering, 2)
 
 #define DECLARE_BIT(_, Name, BitIndex) static const int Name = 1 << BitIndex;
 OPTIMIZATION_FLAGS(DECLARE_BIT)
 #undef DECLARE_BIT
 
 // Test cases source positions are checked for. Please ensure all
 // combinations of flags are present here. This is done manually
 // because it provides easier to comprehend failure case for humans.
-#define TEST_CASES(V)                            \
-  V(UsingReo, kUseReo)                           \
-  V(UsingReoAndPeephole, kUseReo | kUsePeephole) \
-  V(UsingPeephole, kUsePeephole)
+#define TEST_CASES(V)                                                        \
+  V(UsingReo, kUseReo)                                                       \
+  V(UsingPeephole, kUsePeephole)                                             \
+  V(UsingReoAndPeephole, kUseReo | kUsePeephole)                             \
+  V(UsingPositionFiltering, kUsePositionFiltering)                           \
+  V(UsingReoAndPositionFiltering, kUseReo | kUsePositionFiltering)           \
+  V(UsingPeepholeAndPositionFiltering, kUsePeephole | kUsePositionFiltering) \
+  V(UsingAllOptimizations, kUseReo | kUsePeephole | kUsePositionFiltering)
 
 static const char* kTestScripts[] = {
     "var x = (y = 3) + (x = y); return x + y;",
 
     "var x = 55;\n"
     "var y = x + (x = 1) + (x = 2) + (x = 3);\n"
     "return y;",
 
     "var x = 10; return x >>> 3;",
 
@@ skipping 169 matching lines @@
 
 void TestSourcePositionsEquivalent(int optimization_bitmap) {
   HandleAndZoneScope handles;
   // Ensure handler table is generated.
   handles.main_isolate()->interpreter()->Initialize();
 
   OptimizedBytecodeSourcePositionTester tester(handles.main_isolate());
   for (auto test_script : kTestScripts) {
     CHECK(tester.SourcePositionsMatch(optimization_bitmap, test_script));
   }
+
+  CHECK(tester.SourcePositionsMatch(
+      optimization_bitmap, "return some_global[name];", "name", "'a'"));

[rmcilroy, 2016/06/08 13:45:11]

Can this just be added to kTestScripts ?

[oth, 2016/06/08 15:04:21]

Done.

 }
 
 #define MAKE_TEST(Name, Bitmap)               \
   TEST(TestSourcePositionsEquivalent##Name) { \
     TestSourcePositionsEquivalent(Bitmap);    \
   }
 TEST_CASES(MAKE_TEST)
 #undef MAKE_TEST
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8