Remove base/move.h

Remove base/move.h

It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.

BUG=566182
Committed: https://crrev.com/bb5161ab7ad524a9bced788f8099e786946f3a44
Committed: https://crrev.com/1a2fd6cd9275d2fdd909c2f867ae57744bfa4e49
Cr-Original-Commit-Position: refs/heads/master@{#398237}
Cr-Commit-Position: refs/heads/master@{#398384}

[dcheng, 2016-06-06 18:06:06]

Description was changed from

==========
Ummm.

BUG=
==========

to

==========
Remove base/move.h

BUG=
==========

[dcheng, 2016-06-06 18:07:24]

Description was changed from

==========
Remove base/move.h

BUG=
==========

to

==========
Remove base/move.h

It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.

BUG=566182
==========

[dcheng, 2016-06-06 18:07:24]

dcheng@chromium.org changed reviewers:
+ thakis@chromium.org, yzshen@chromium.org

[dcheng, 2016-06-06 18:08:29]

+thakis for overall review.

+yzshen for changes in //mojo/public/cpp/bindings/lib/template_util.h: this is
how we implemented IsMoveOnlyType in //base, before tzik@ removed the need for
this template completely. The same trick should be safe to use in //mojo, but
I'd like confirmation =)

[Nico, 2016-06-06 18:21:54]

lgtm

https://codereview.chromium.org/2038273002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/lib/template_util.h (right):

https://codereview.chromium.org/2038273002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/lib/template_util.h:57: static const bool value
=base::is_move_assignable<T>::value &&
i suppose this is clang-format getting this wrong? is this still broken at
trunk? (if so, can you file a PR?)

[dcheng, 2016-06-06 18:26:42]

wtb global clang-format presubmit hook

https://codereview.chromium.org/2038273002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/lib/template_util.h (right):

https://codereview.chromium.org/2038273002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/lib/template_util.h:57: static const bool value
=base::is_move_assignable<T>::value &&
On 2016/06/06 at 18:21:53, Nico wrote:
> i suppose this is clang-format getting this wrong? is this still broken at
trunk? (if so, can you file a PR?)

Oops, this is me forgetting to upload the clang formatted patch. Done.

[yzshen1, 2016-06-06 19:46:50]

mojo/*  LGTM

Glad to see this change!

[dcheng, 2016-06-06 21:32:10]

dcheng@chromium.org changed reviewers:
+ jam@chromium.org

[dcheng, 2016-06-06 21:32:11]

+jam, mind giving a global OWNERS stamp for this cleanup CL?

[jam, 2016-06-06 22:10:11]

lgtm

[dcheng, 2016-06-07 00:32:06]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-06-07 00:32:07]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2038273002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-06-07 00:32:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038273002/60001

[commit-bot: I haz the power, 2016-06-07 05:37:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-07 05:39:20]

Description was changed from

==========
Remove base/move.h

It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.

BUG=566182
==========

to

==========
Remove base/move.h

It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.

BUG=566182

Committed: https://crrev.com/bb5161ab7ad524a9bced788f8099e786946f3a44
Cr-Commit-Position: refs/heads/master@{#398237}
==========

[commit-bot: I haz the power, 2016-06-07 05:39:23]

Patchset 4 (id:??) landed as
https://crrev.com/bb5161ab7ad524a9bced788f8099e786946f3a44
Cr-Commit-Position: refs/heads/master@{#398237}

[tzik, 2016-06-07 07:09:59]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2047633002/ by tzik@chromium.org.

The reason for reverting is: This breaks the Windows build on the waterfall.
The error log is:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com...

FAILED: obj/ash/mus/lib/shelf_layout_impl.obj 
ninja -t msvc -e environment.x86 -- E:\b\build\slave\cache\cipd\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe"
/nologo /showIncludes /FC @obj/ash/mus/lib/shelf_layout_impl.obj.rsp /c
../../ash/mus/shelf_layout_impl.cc /Foobj/ash/mus/lib/shelf_layout_impl.obj
/Fd"obj/ash/mus/lib_cc.pdb"
e:\b\build\slave\win\build\src\base\template_util.h(65): error C2718:
'ui::LatencyInfo': actual parameter with requested alignment of 8 won't be
aligned
e:\b\build\slave\win\build\src\base\template_util.h(86): note: see reference to
class template instantiation
'base::internal::IsAssignableImpl<Lvalue,Rvalue,false>' being compiled
        with
        [
            Lvalue=ui::LatencyInfo &,
            Rvalue=ui::LatencyInfo &&
        ]
e:\b\build\slave\win\build\src\base\template_util.h(103): note: see reference to
class template instantiation 'base::is_assignable<ui::LatencyInfo
&,ui::LatencyInfo &&>' being compiled
e:\b\build\slave\win\build\src\mojo\public\cpp\bindings\lib\template_util.h(58):
note: see reference to class template instantiation
'base::is_move_assignable<T>' being compiled
        with
        [
            T=ui::LatencyInfo
        ]
e:\b\build\slave\win\build\src\mojo\public\cpp\bindings\array.h(34): note: see
reference to class template instantiation
'mojo::internal::IsMoveOnlyType<MojomType>' being compiled
        with
        [
            MojomType=ui::LatencyInfo
        ]
e:\b\build\slave\win\build\src\out\debug\gen\cc\ipc\compositor_frame_metadata.mojom.h(121):
note: see reference to class template instantiation
'mojo::Array<ui::LatencyInfo>' being compiled.

[dcheng, 2016-06-07 16:57:44]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[dcheng, 2016-06-07 16:58:15]

That's really weird: this patch went through that bot successfully when it
landed...

[commit-bot: I haz the power, 2016-06-07 16:58:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038273002/60001

[commit-bot: I haz the power, 2016-06-07 17:02:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 17:02:58]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-06-07 19:42:25]

yzshen@, ptal. I just changed Mojo's IsMoveOnlyType to use std::is_constructible
instead. I haven't had time to dive into the details of why this only fails on
MSVC, but I'd rather just get this cleaned up and figure it out later (if at
all).

[yzshen1, 2016-06-07 21:05:17]

On 2016/06/07 19:42:25, dcheng wrote:
> yzshen@, ptal. I just changed Mojo's IsMoveOnlyType to use
std::is_constructible
> instead. I haven't had time to dive into the details of why this only fails on
> MSVC, but I'd rather just get this cleaned up and figure it out later (if at
> all).

LGTM.

I do wish we could figure out why the previous approach failed. People may want
to use those base template utilities and run into the same problem.

[dcheng, 2016-06-07 21:05:51]

On 2016/06/07 at 21:05:17, yzshen wrote:
> On 2016/06/07 19:42:25, dcheng wrote:
> > yzshen@, ptal. I just changed Mojo's IsMoveOnlyType to use
std::is_constructible
> > instead. I haven't had time to dive into the details of why this only fails
on
> > MSVC, but I'd rather just get this cleaned up and figure it out later (if at
> > all).
> 
> LGTM.
> 
> I do wish we could figure out why the previous approach failed. People may
want to use those base template utilities and run into the same problem.

Yeah I'll try to reduce separately and see if I can file a bug upstream / fix
our templates / whatever.

[dcheng, 2016-06-07 21:07:28]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-06-07 21:07:28]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2038273002/#ps80001
(title: "is_constructible")

[commit-bot: I haz the power, 2016-06-07 21:23:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038273002/80001

[commit-bot: I haz the power, 2016-06-07 21:39:25]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-07 21:41:39]

Description was changed from

==========
Remove base/move.h

It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.

BUG=566182

Committed: https://crrev.com/bb5161ab7ad524a9bced788f8099e786946f3a44
Cr-Commit-Position: refs/heads/master@{#398237}
==========

to

==========
Remove base/move.h

It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.

BUG=566182

Committed: https://crrev.com/bb5161ab7ad524a9bced788f8099e786946f3a44
Committed: https://crrev.com/1a2fd6cd9275d2fdd909c2f867ae57744bfa4e49
Cr-Original-Commit-Position: refs/heads/master@{#398237}
Cr-Commit-Position: refs/heads/master@{#398384}
==========

[commit-bot: I haz the power, 2016-06-07 21:41:41]

Patchset 5 (id:??) landed as
https://crrev.com/1a2fd6cd9275d2fdd909c2f867ae57744bfa4e49
Cr-Commit-Position: refs/heads/master@{#398384}