Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: content/public/browser/navigation_entry.h

Issue 2038233002: Using ResourceRequestBody as the type of HTTP body outside of //content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make-resource-request-body-public
Patch Set: Addressed CR feedback from creis@. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/navigation_controller.cc ('k') | content/public/browser/page_navigator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_entry.h
diff --git a/content/public/browser/navigation_entry.h b/content/public/browser/navigation_entry.h
index a68e66151ba604d5b19e64a974a0d1748a674f30..4ac51e35e055145b712c7e7e5ad0cbd6d42c1173 100644
--- a/content/public/browser/navigation_entry.h
+++ b/content/public/browser/navigation_entry.h
@@ -17,6 +17,7 @@
#include "content/common/content_export.h"
#include "content/public/common/page_type.h"
#include "content/public/common/referrer.h"
+#include "content/public/common/resource_request_body.h"
#include "ui/base/page_transition_types.h"
class GURL;
@@ -139,7 +140,7 @@ class NavigationEntry {
// whether the page had post data.
//
// The actual post data is stored either in
- // 1) browser_initiated_post_data when a new post data request is started.
+ // 1) post_data when a new post data request is started.
// 2) content_state when a post request has started and is extracted by
Charlie Reis 2016/06/10 20:59:28 PageState
Łukasz Anforowicz 2016/06/13 18:01:11 Done.
// WebKit to actually make the request.
virtual void SetHasPostData(bool has_post_data) = 0;
@@ -149,16 +150,15 @@ class NavigationEntry {
virtual void SetPostID(int64_t post_id) = 0;
virtual int64_t GetPostID() const = 0;
- // Holds the raw post data of a browser initiated post request.
+ // Holds the raw post data of a post request.
// For efficiency, this should be cleared when content_state is populated
Charlie Reis 2016/06/10 20:59:28 PageState
Łukasz Anforowicz 2016/06/13 18:01:11 Done.
// since the data is duplicated.
// Note, this field:
// 1) is not persisted in session restore.
// 2) is shallow copied with the static copy Create method above.
// 3) may be nullptr so check before use.
- virtual void SetBrowserInitiatedPostData(
- const base::RefCountedMemory* data) = 0;
- virtual const base::RefCountedMemory* GetBrowserInitiatedPostData() const = 0;
+ virtual void SetPostData(const scoped_refptr<ResourceRequestBody>& data) = 0;
+ virtual scoped_refptr<ResourceRequestBody> GetPostData() const = 0;
// The favicon data and tracking information. See content::FaviconStatus.
virtual const FaviconStatus& GetFavicon() const = 0;
« no previous file with comments | « content/public/browser/navigation_controller.cc ('k') | content/public/browser/page_navigator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698