Using ResourceRequestBody as the type of HTTP body outside of //content.

content/public/browser/page_navigator.h

Index: content/public/browser/page_navigator.h
diff --git a/content/public/browser/page_navigator.h b/content/public/browser/page_navigator.h
index 51f02349648b33ccd72ab4ae6a47b184985cb057..fa7cebd2e6be249bcbc71e3fc3d5d2a52f2eebb6 100644
--- a/content/public/browser/page_navigator.h
+++ b/content/public/browser/page_navigator.h
@@ -12,11 +12,11 @@
 #include <string>
 
 #include "base/memory/ref_counted.h"
-#include "base/memory/ref_counted_memory.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/global_request_id.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/common/referrer.h"
+#include "content/public/common/resource_request_body.h"
 #include "ui/base/page_transition_types.h"
 #include "ui/base/window_open_disposition.h"
 #include "url/gurl.h"
@@ -52,13 +52,10 @@ struct CONTENT_EXPORT OpenURLParams {
   std::vector<GURL> redirect_chain;
 
   // Indicates whether this navigation will be sent using POST.
-  // The POST method is limited support for basic POST data by leveraging
-  // NavigationController::LOAD_TYPE_BROWSER_INITIATED_HTTP_POST.
-  // It is not for things like file uploads.

[Charlie Reis, 2016/06/09 22:38:16]

Sanity check: Android apps won't be gaining an unexpected ability to do file
uploads via this change, right?  ResourceRequestBody would support that, but I
think there's no way for Java code to pass it in.

[Łukasz Anforowicz, 2016/06/10 19:20:50]

Correct.  2 reasons why this cannot happen:

1. Native (i.e. C++) content/public/common/resource_request_body.h only exposes
a function to create ResourceRequestBody out of a vector of bytes.

2. Java's
content/public/android/java/src/org/chromium/content_public/common/ResourceRequestBody.java
(added in this CL) only has 1 public method - create (taking an array of bytes).

   bool uses_post;
 
   // The post data when the navigation uses POST.
-  scoped_refptr<base::RefCountedMemory> browser_initiated_post_data;
+  scoped_refptr<ResourceRequestBody> post_data;
 
   // Extra headers to add to the request for this page.  Headers are
   // represented as "<name>: <value>" and separated by \r\n.  The entire string