Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 203823005: Address build spew. (Closed)

Created:
6 years, 9 months ago by newt (away)
Modified:
6 years, 9 months ago
Reviewers:
Yaron
CC:
chromium-reviews, craigdh+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, dtseng+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, dmazzoni+watch_chromium.org
Visibility:
Public.

Description

Address build spew. - Fix Android lint warning about using the default locale in BrowserAccessibilityManager.java - Suppress javac deprecation warning about AbsoluteLayout, which we're deliberately using and which isn't going away anytime soon. - Suppress lint warning about using Context.PRINT_SERVICE constant, which was added in API level 19, since we only create the print service when API level is >=19. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 3 chunks +2 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
newt (away)
PTAL, thanks!
6 years, 9 months ago (2014-03-18 20:51:01 UTC) #1
Yaron
lgtm
6 years, 9 months ago (2014-03-19 17:36:23 UTC) #2
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 9 months ago (2014-03-20 05:11:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/203823005/1
6 years, 9 months ago (2014-03-20 05:12:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 05:14:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-20 05:14:32 UTC) #6
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 9 months ago (2014-03-20 05:16:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/203823005/1
6 years, 9 months ago (2014-03-20 05:17:05 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 08:25:35 UTC) #9
Message was sent while issue was closed.
Change committed as 258249

Powered by Google App Engine
This is Rietveld 408576698