Issue 2038203002: Fix various nefarious problems with the script table used in source reports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2038203002: Fix various nefarious problems with the script table used in source reports. (Closed)

Created:
4 years, 6 months ago by turnidge

Modified:
4 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Chris Bracken

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix various nefarious problems with the script table used in source reports. Before we could get duplicate or spurious script table entries. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/424ca27a150db9985d121f04024ce09e0c34d85e

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -13 lines)			Patch
M	runtime/vm/source_report.h	View	4 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/source_report.cc	View	4 chunks	+45 lines, -12 lines	0 comments	Download
M	runtime/vm/source_report_test.cc	View	1 chunk	+43 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

turnidge

4 years, 6 months ago (2016-06-06 18:22:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
424ca27a150db9985d121f04024ce09e0c34d85e (presubmit successful).