Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2038193003: Ignore exceptions from MediaDrmBridge.closeSession() (Closed)

Created:
4 years, 6 months ago by Tima Vaisburd
Modified:
4 years, 6 months ago
Reviewers:
qinmin, xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org, sgurun-gerrit only
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore exceptions from MediaDrmBridge.closeSession() It seems some implementations thow an undocumented exception from MediaDrm.closeSession(). This CL catches and ignores all of them. BUG=611865 Committed: https://crrev.com/21981b3175fa8c6fd0d8f9eee7bf41e7f8f2c277 Cr-Commit-Position: refs/heads/master@{#398093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -6 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaDrmBridge.java View 6 chunks +37 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Tima Vaisburd
I cannot reproduce the problem, this is a defensive move. PTAL.
4 years, 6 months ago (2016-06-03 23:43:28 UTC) #2
xhwang
I am feeling sad about all these types of catches. But thank you for the ...
4 years, 6 months ago (2016-06-04 00:11:30 UTC) #3
Tima Vaisburd
On 2016/06/04 00:11:30, xhwang wrote: > I am feeling sad about all these types of ...
4 years, 6 months ago (2016-06-04 00:14:21 UTC) #4
qinmin
lgtm
4 years, 6 months ago (2016-06-06 18:01:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038193003/1
4 years, 6 months ago (2016-06-06 18:19:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 19:35:54 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 19:37:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21981b3175fa8c6fd0d8f9eee7bf41e7f8f2c277
Cr-Commit-Position: refs/heads/master@{#398093}

Powered by Google App Engine
This is Rietveld 408576698