Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2038153003: Create ClassElement.type lazily in ClassElementImpl and EnumElementImpl. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create ClassElement.type lazily in ClassElementImpl and EnumElementImpl. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/674fc7829b7b6b4b29b12e35218a8e868be10f09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -43 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 3 chunks +3 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 5 chunks +30 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 2 chunks +2 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +1 line, -6 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 6 months ago (2016-06-03 21:02:34 UTC) #1
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-03 21:12:14 UTC) #2
scheglov
4 years, 6 months ago (2016-06-03 21:35:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
674fc7829b7b6b4b29b12e35218a8e868be10f09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698