Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2038153002: fix tests for dart2js-mac10.11-chrome-be (Closed)

Created:
4 years, 6 months ago by Harry Terkelsen
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix tests for dart2js-mac10.11-chrome-be BUG= Committed: https://github.com/dart-lang/sdk/commit/1fa0ccf869f351a4a80df4ec00c90278a6e45880

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M tests/co19/co19-dart2js.status View 1 9 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
putting a "Pass" in a later, more specific section will cause it to override a ...
4 years, 6 months ago (2016-06-03 20:34:47 UTC) #2
Siggi Cherem (dart-lang)
I believe no, it will mark it as flaky. Easy way to test it out ...
4 years, 6 months ago (2016-06-03 20:38:52 UTC) #3
Harry Terkelsen
Committed patchset #2 (id:20001) manually as 1fa0ccf869f351a4a80df4ec00c90278a6e45880 (presubmit successful).
4 years, 6 months ago (2016-06-03 20:58:03 UTC) #5
Siggi Cherem (dart-lang)
4 years, 6 months ago (2016-06-03 21:00:30 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698