Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2038133004: Make NativePixmap unittests use TEXTURE_EXTERNAL_OES. (Closed)

Created:
4 years, 6 months ago by Daniele Castagna
Modified:
4 years, 6 months ago
Reviewers:
reveman, ccameron
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make NativePixmap unittests use TEXTURE_EXTERNAL_OES. NativePixmap unittests were incorrectly using TEXTURE_2D target. TEST='gl_unittests --gtest_also_run_disabled_tests' on samus Committed: https://crrev.com/e5cea98fbaf6c37dc8818d1a96779263ad3ac941 Cr-Commit-Position: refs/heads/master@{#397857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M ui/gl/gl_image_ozone_native_pixmap_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/test/gl_image_test_template.h View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Daniele Castagna
4 years, 6 months ago (2016-06-03 23:01:07 UTC) #2
reveman
lgtm
4 years, 6 months ago (2016-06-03 23:34:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038133004/1
4 years, 6 months ago (2016-06-03 23:37:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/195142)
4 years, 6 months ago (2016-06-03 23:46:08 UTC) #7
Daniele Castagna
+ccameron for ownership.
4 years, 6 months ago (2016-06-03 23:46:49 UTC) #9
Daniele Castagna
On 2016/06/03 at 23:46:49, Daniele Castagna wrote: > +ccameron for ownership. Chris, you can LGTM ...
4 years, 6 months ago (2016-06-04 00:07:41 UTC) #10
ccameron
lgtm
4 years, 6 months ago (2016-06-04 00:28:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038133004/1
4 years, 6 months ago (2016-06-04 00:34:21 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 00:40:06 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:41:11 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5cea98fbaf6c37dc8818d1a96779263ad3ac941
Cr-Commit-Position: refs/heads/master@{#397857}

Powered by Google App Engine
This is Rietveld 408576698