Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 203813003: Remove GN integration code from gyp_chromium. (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Remove GN integration code from gyp_chromium. We are no longer persuing the hybrid mode. R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259918

Patch Set 1 #

Total comments: 2

Patch Set 2 : More conservative #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -160 lines) Patch
M build/gyp_chromium View 1 6 chunks +7 lines, -160 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
https://codereview.chromium.org/203813003/diff/1/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/203813003/diff/1/build/gyp_chromium#newcode326 build/gyp_chromium:326: gn_vars_dict.get('OS') in ['android', 'ios'], Help! I don't know what ...
6 years, 9 months ago (2014-03-18 18:30:15 UTC) #1
Nico
https://codereview.chromium.org/203813003/diff/1/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/203813003/diff/1/build/gyp_chromium#newcode326 build/gyp_chromium:326: gn_vars_dict.get('OS') in ['android', 'ios'], On 2014/03/18 18:30:16, brettw wrote: ...
6 years, 9 months ago (2014-03-19 11:04:59 UTC) #2
brettw
I kept the vars dictionary and just removed the GN-related stuff from it. PTAL
6 years, 9 months ago (2014-03-20 20:12:28 UTC) #3
brettw
ping
6 years, 9 months ago (2014-03-27 16:26:01 UTC) #4
Nico
lgtm
6 years, 9 months ago (2014-03-27 16:39:25 UTC) #5
brettw
6 years, 9 months ago (2014-03-27 17:07:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r259918 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698