💰 target_cpu -> current_cpu in remoting/android/BUILD.gn, remoting_apk_tmpl.gni

target_cpu -> current_cpu in remoting/android/BUILD.gn, remoting_apk_tmpl.gni

BUG=616819
Committed: https://crrev.com/ea632704f3232934db1f0b21c1f8c9259d39229a
Cr-Commit-Position: refs/heads/master@{#398577}

[agrieve, 2016-06-03 17:18:32]

agrieve@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Lambros, 2016-06-03 17:56:46]

lgtm

'current_cpu' is news to me :)

https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cross_c...
isn't very clear about the meaning. It talks about *current* CPU/OS settings,
but doesn't explain how a setting can ever be non-current. So it's not clear to
a BUILD.gn author how to decide whether to use 'current_foo' or 'target_foo'.

[Sergey Ulanov, 2016-06-03 20:00:49]

sergeyu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2016-06-03 20:00:49]

If I understand correctly current_cpu is a property of the current toolchain,
while target_cpu is the same no matter which toolchain is being used. E.g. when
compiling our pnacl plugin current_cpu is set to 'pnacl', while target_cpu is
still x86 or x64

[Sergey Ulanov, 2016-06-03 20:01:15]

Description was changed from

==========
target_cpu -> current_cpu in remoting/android/BUILD.gn, remoting_apk_tmpl.gni

BUG=616819
==========

to

==========
target_cpu -> current_cpu in remoting/android/BUILD.gn, remoting_apk_tmpl.gni

BUG=616819
==========

[Sergey Ulanov, 2016-06-03 20:01:15]

sergeyu@chromium.org changed reviewers:
- sergeyu@chromium.org

[agrieve, 2016-06-03 20:28:09]

On 2016/06/03 17:56:46, Lambros wrote:
> lgtm
> 
> 'current_cpu' is news to me :)
> 
>
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cross_c...
> isn't very clear about the meaning. It talks about *current* CPU/OS settings,
> but doesn't explain how a setting can ever be non-current. So it's not clear
to
> a BUILD.gn author how to decide whether to use 'current_foo' or 'target_foo'.

Agreed. I've got an update for it here:
https://codereview.chromium.org/2038733003

[agrieve, 2016-06-08 14:40:30]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-06-08 14:40:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038113002/1

[commit-bot: I haz the power, 2016-06-08 16:03:31]

Description was changed from

==========
target_cpu -> current_cpu in remoting/android/BUILD.gn, remoting_apk_tmpl.gni

BUG=616819
==========

to

==========
target_cpu -> current_cpu in remoting/android/BUILD.gn, remoting_apk_tmpl.gni

BUG=616819
==========

[commit-bot: I haz the power, 2016-06-08 16:03:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-08 16:06:22]

Description was changed from

==========
target_cpu -> current_cpu in remoting/android/BUILD.gn, remoting_apk_tmpl.gni

BUG=616819
==========

to

==========
target_cpu -> current_cpu in remoting/android/BUILD.gn, remoting_apk_tmpl.gni

BUG=616819

Committed: https://crrev.com/ea632704f3232934db1f0b21c1f8c9259d39229a
Cr-Commit-Position: refs/heads/master@{#398577}
==========

[commit-bot: I haz the power, 2016-06-08 16:06:23]

Patchset 1 (id:??) landed as
https://crrev.com/ea632704f3232934db1f0b21c1f8c9259d39229a
Cr-Commit-Position: refs/heads/master@{#398577}