Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 20381: Fix crasher in GetDefaultSearchEngineName() in first run bubble.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix crasher in GetDefaultSearchEngineName() in first run bubble. - It seems that BrowserList::GetLastActive() is returning null, probably it takes longer now for the browser to become active. - But rather than guessing the profile, get it from the guts of the location bar. - crasher is ranked #34 by Laforge BUG=6211 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9916

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M chrome/browser/views/first_run_bubble.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/views/first_run_bubble.cc View 1 2 5 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/views/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 5 (0 generated)
cpu_(ooo_6.6-7.5)
8 years, 7 months ago (2009-02-14 03:22:30 UTC) #1
cpu_(ooo_6.6-7.5)
8 years, 7 months ago (2009-02-14 03:22:46 UTC) #2
sky
http://codereview.chromium.org/20381/diff/1/2 File chrome/browser/views/first_run_bubble.cc (right): http://codereview.chromium.org/20381/diff/1/2#newcode33 Line 33: const Browser* browser = BrowserList::GetLastActive(); Rather than guessing ...
8 years, 7 months ago (2009-02-17 16:37:48 UTC) #3
cpu_(ooo_6.6-7.5)
You're right. The universe has shifted and now it is easy to pass down the ...
8 years, 7 months ago (2009-02-17 22:35:10 UTC) #4
sky
8 years, 7 months ago (2009-02-17 22:38:49 UTC) #5
Coolness. I wouldn't mind an additional DCHECK. Otherwise, LGTM.

http://codereview.chromium.org/20381/diff/6/1003
File chrome/browser/views/first_run_bubble.cc (right):

http://codereview.chromium.org/20381/diff/6/1003#newcode34
Line 34: return std::wstring();
Seems like you should always have a profile. Is it worth a DCHECK here?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b