chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc - Issue 2038083004: Reland of ExtensionFunction: don't pass ownership of base::Value by raw pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc

Issue 2038083004: Reland of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.h ('k') | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc

diff --git a/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc b/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc

index 5f8296193a7787d8962703a9c983c1bde9ab66ed..a2563e222b3270dba131789a0ca288e45ec5990c 100644

--- a/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc

+++ b/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc

@@ -63,9 +63,9 @@

data_usage_buckets->Append(std::move(connection_usage_list));

}

- base::DictionaryValue* result = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());

result->Set("data_usage_buckets", std::move(data_usage_buckets));

- Respond(OneArgument(result));

+ Respond(OneArgument(std::move(result)));

}

} // namespace extensions